Bug 162979 - URLParser should correctly strip unnecessary 0's in IPv6 addresses
Summary: URLParser should correctly strip unnecessary 0's in IPv6 addresses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-05 10:52 PDT by Alex Christensen
Modified: 2016-10-05 11:30 PDT (History)
0 users

See Also:

Attachments
Patch (4.20 KB, patch)
2016-10-05 10:54 PDT, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-05 10:52:56 PDT 
URLParser should correctly strip unnecessary 0's in IPv6 addresses
Comment 1 Alex Christensen 2016-10-05 10:54:06 PDT 
Created attachment 290727 [details]
Patch
Comment 2 Alex Christensen 2016-10-05 11:30:48 PDT 
Comment on attachment 290727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290727&action=review

> Source/WebCore/platform/URLParser.cpp:2318
> +        if (UNLIKELY((value && leadingZeros) || (!value && length > 1) || (length > 1 && !value)))

Oops.  This was redundant.  Removed one of the checks.
Comment 3 Alex Christensen 2016-10-05 11:30:56 PDT 
http://trac.webkit.org/changeset/206819