Bug 162967 - [Readable Streams API] Align function names with spec
Summary: [Readable Streams API] Align function names with spec
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
Depends on:
Reported: 2016-10-05 05:35 PDT by Romain Bellessort
Modified: 2016-10-05 09:48 PDT (History)
3 users (show)

See Also:

Patch (13.99 KB, patch)
2016-10-05 05:51 PDT, Romain Bellessort
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-10-05 05:35:57 PDT
Readable Streams API implementation has globally been aligned with latest spec, but functions names were not always updated in order to ease patch review. In some cases, this leads to inconsistencies (e.g. enqueueInReadableStream takes a controller argument whereas its name suggests it works on a stream). Aligning with spec names would make code more coherent and ease comparison between implementation and spec.
Comment 1 Romain Bellessort 2016-10-05 05:51:32 PDT
Created attachment 290706 [details]
Comment 2 WebKit Commit Bot 2016-10-05 09:48:48 PDT
Comment on attachment 290706 [details]

Clearing flags on attachment: 290706

Committed r206814: <http://trac.webkit.org/changeset/206814>
Comment 3 WebKit Commit Bot 2016-10-05 09:48:51 PDT
All reviewed patches have been landed.  Closing bug.