Bug 162962 – [SOUP] Ensure NetworkProcess is ready before whitelisting TLS certificates

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Emanuele Aina]

If the API user tries to whitelist TLS certificates before any web view has been created, the action will be ignored because the NetworkProcess hasn't been fired up yet.

For example, the snippet below using the GTK+ API does not work, unless the whitelisting is moved after the web view creation:
                                                                                                                        
    webkit_web_context_allow_tls_certificate_for_host(webkit_web_context_get_default(), crt, host);
    webView = webkit_web_view_new();

[Emanuele Aina]

Created attachment 290698 [details]
Patch

[Alex Christensen]

I'm not opposed to this change, but long-term we're hoping to get rid of it.  See discussion in https://bugs.webkit.org/show_bug.cgi?id=162910
Is it still wanted?

[Emanuele Aina]

I just stumbled on this unexpected behaviour where the whitelisting silently failed, I'll leave any other consideration to Michael and Carlos. :)

[Alex Christensen]

Comment on attachment 290698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290698&action=review

r=me, but hopefully we'll remove this whole feature soon.  You can decide if you want to land it.

> w/Source/WebKit2/UIProcess/WebProcessPool.cpp:1149
> +    ASSERT(m_networkProcess);

not necessary

[Michael Catanzaro]

We can't remove the feature, it's part of our API and we intend to support it indefinitely. What we can do is reimplement the feature at the GTK API layer using whatever UI process callbacks get added, then it can be removed from the cross-platform WebKit2 code.

[Michael Catanzaro]

Comment on attachment 290698 [details]
Patch

Indeed, the ASSERT is not helpful here.

This looks easy to test, so if you don't want to risk it breaking in the next refactoring, it would be nice if you could try to add a test for it in TestSSL.cpp. The only trick is that you can't use the nice SSLTest class since that doesn't give you the ability to use the WebKitWebContext before the WebKitWebView is created; you'd have to roll your own that inherits from Test rather than LoadTrackingTest/WebViewTest.

[Michael Catanzaro]

Emanuele, I think you should commit this (without the ASSERT) even if you don't have time to write a test.

[Michael Catanzaro]

Did this get forgotten?

[Michael Catanzaro]

Let's land this.

[Michael Catanzaro]

Committed r210180: <http://trac.webkit.org/changeset/210180>

[Emanuele Aina]

I tried to come up with a test, but then I failed to find the time to finish it. Thank you for taking care of the patch!