Bug 162956 - UTF-8 encode queries of nonspecial and websocket schemes
Summary: UTF-8 encode queries of nonspecial and websocket schemes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-04 23:32 PDT by Alex Christensen
Modified: 2016-10-05 11:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.49 KB, patch)
2016-10-05 00:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (15.90 KB, patch)
2016-10-05 11:03 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-04 23:32:36 PDT
UTF-8 encode queries of nonspecial and websocket schemes
Comment 1 Alex Christensen 2016-10-05 00:05:59 PDT
Created attachment 290693 [details]
Patch
Comment 2 Alex Christensen 2016-10-05 11:03:35 PDT
Created attachment 290728 [details]
Patch
Comment 3 Geoffrey Garen 2016-10-05 11:11:42 PDT
Comment on attachment 290728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        'If url is not special or urlâs scheme is either "ws" or "wss", set encoding to UTF-8.'

ASCII in ChangeLog please.
Comment 4 Brady Eidson 2016-10-05 11:14:47 PDT
Comment on attachment 290728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290728&action=review

> Source/WebCore/platform/URLParser.cpp:680
> +    Ws,
> +    Wss,

All caps

> Source/WebCore/platform/URLParser.cpp:682
> +    Ftp,

All caps

> Source/WebCore/platform/URLParser.cpp:685
> +    Http,
> +    Https,

All caps
Comment 5 Alex Christensen 2016-10-05 11:28:03 PDT
Done, and added a gopher test just for fun
http://trac.webkit.org/changeset/206818