Introduce InputEvent bindings in preparation for the input events spec
Created attachment 290708 [details] First pass
Created attachment 290709 [details] Added InputEvent to CMakeLists.
Comment on attachment 290709 [details] Added InputEvent to CMakeLists. View in context: https://bugs.webkit.org/attachment.cgi?id=290709&action=review > Source/WebCore/dom/InputEvent.h:56 > + void initInputEvent(const String& inputType); I realized I don't actually need this method -- removed.
Comment on attachment 290709 [details] Added InputEvent to CMakeLists. Attachment 290709 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2224980 New failing tests: js/dom/global-constructors-attributes.html
Created attachment 290718 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 290719 [details] Added InputEvent to constructor test expectations.
Comment on attachment 290719 [details] Added InputEvent to constructor test expectations. View in context: https://bugs.webkit.org/attachment.cgi?id=290719&action=review > Source/WebCore/testing/InternalSettings.h:175 > + bool inputEventsEnabled(ExceptionCode&); > + void setInputEventsEnabled(bool, ExceptionCode&); Are these necessary? I would assume they would be generated automatically in InternalSettingsGenerated since you put this in Settings.in
Comment on attachment 290719 [details] Added InputEvent to constructor test expectations. View in context: https://bugs.webkit.org/attachment.cgi?id=290719&action=review >> Source/WebCore/testing/InternalSettings.h:175 >> + void setInputEventsEnabled(bool, ExceptionCode&); > > Are these necessary? I would assume they would be generated automatically in InternalSettingsGenerated since you put this in Settings.in I believe these definitions are still necessary, since this is InternalSettings. It's not needed in Settings.h, since that uses Settings.in to generate the relevant getters/setters in SettingsMacros.h and insert them via the SETTINGS_GETTERS_AND_SETTERS macro.
(In reply to comment #8) > Comment on attachment 290719 [details] > Added InputEvent to constructor test expectations. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290719&action=review > > >> Source/WebCore/testing/InternalSettings.h:175 > >> + void setInputEventsEnabled(bool, ExceptionCode&); > > > > Are these necessary? I would assume they would be generated automatically in InternalSettingsGenerated since you put this in Settings.in > > I believe these definitions are still necessary, since this is > InternalSettings. It's not needed in Settings.h, since that uses Settings.in > to generate the relevant getters/setters in SettingsMacros.h and insert them > via the SETTINGS_GETTERS_AND_SETTERS macro. Never mind, I see what you mean. The version of the getter/setter I defined in InternalSettings is one with exceptions, which isn’t generated automatically in derived sources. It looks like it's being invoked by JS bindings, since I specified in the IDL that the setter/getter may throw exceptions. Should I remove these exception-throwing versions of the getter/setter?
Comment on attachment 290719 [details] Added InputEvent to constructor test expectations. Attachment 290719 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2225350 New failing tests: fast/events/input-events-fired-when-typing.html
Created attachment 290733 [details] Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 290719 [details] Added InputEvent to constructor test expectations. View in context: https://bugs.webkit.org/attachment.cgi?id=290719&action=review r=me assuming you address Sam's comment and fix or skip the test on iOS. > LayoutTests/fast/events/input-events-fired-when-typing.html:27 > + eventSender.keyDown("a", []); You probably need to skip this test on iOS due to eventSender not working on iOS. > LayoutTests/fast/events/input-events-fired-when-typing.html:38 > + shouldBe("event.target.id", "expectedTargetID"); Please also check the values of bubbles, cancelable, and composed.
Created attachment 290775 [details] Patch for landing
Comment on attachment 290775 [details] Patch for landing Clearing flags on attachment: 290775 Committed r206843: <http://trac.webkit.org/changeset/206843>
<rdar://problem/28658043>