Bug 162951 – [iOS] Support Web Archive previews generated by QuickLook

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Support Web Archive previews generated by QuickLook

[Andy Estes]

rdar://problem/28607920

[Andy Estes]

Created attachment 290673 [details]
Patch

[Build Bot]

Comment on attachment 290673 [details]
Patch

Attachment 290673 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2221053

New failing tests:
http/tests/quicklook/secure-document-with-subresources.html

[Build Bot]

Created attachment 290679 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Andy Estes]

Created attachment 291532 [details]
Patch

[Andy Estes]

Created attachment 291534 [details]
Patch

[Brady Eidson]

Comment on attachment 291532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291532&action=review

> Source/WebCore/loader/DocumentLoader.cpp:753
> +    if (!equalLettersIgnoringASCIICase(mimeType, "application/x-webarchive")
> +        && !equalLettersIgnoringASCIICase(mimeType, "application/x-mimearchive")
> +#if PLATFORM(GTK)
> +        && !equalLettersIgnoringASCIICase(mimeType, "message/rfc822")
> +#endif
> +        && !equalLettersIgnoringASCIICase(mimeType, "multipart/related"))
> +        return false;

This segment looks gross to me.

One possible improvement would be to put the PLATFORM(GTK) part as the last clause.
Another possible improvement would be to put the PLATFORM(GTK) part after the x-platform if statement, much like the USE(QUICK_LOOK) segment is.
Another possible improvement would be to have a lookup set that's initialized once (though that might be overkill for only 3-4 entries)

Please change something.

[Brady Eidson]

Comment on attachment 291534 [details]
Patch

My comments for the last one still apply here

[Andy Estes]

Created attachment 291542 [details]
Patch

[Andy Estes]

Created attachment 291543 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 291543 [details]
Patch for landing

Clearing flags on attachment: 291543

Committed r207318: <http://trac.webkit.org/changeset/207318>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

This made an API test assert 100% of the time:

ASSERTION FAILED: string
/Users/alexchristensen/code/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/text/StringHash.h(102) : static unsigned int WTF::ASCIICaseInsensitiveHash::hash(WTF::StringImpl *)
1   0x114b277cd WTFCrash
2   0x117000d1b WTF::ASCIICaseInsensitiveHash::hash(WTF::StringImpl*)
3   0x117000ccd WTF::ASCIICaseInsensitiveHash::hash(WTF::String const&)
4   0x1170e0415 unsigned int WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::ASCIICaseInsensitiveHash>::hash<WTF::String>(WTF::String const&)
5   0x1173ed220 WTF::String* WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::ASCIICaseInsensitiveHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::inlineLookup<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::ASCIICaseInsensitiveHash>, WTF::String>(WTF::String const&)
6   0x1173ed1bd WTF::String* WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::ASCIICaseInsensitiveHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::lookup<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::ASCIICaseInsensitiveHash>, WTF::String>(WTF::String const&)
7   0x1173ed178 bool WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::ASCIICaseInsensitiveHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::contains<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::ASCIICaseInsensitiveHash>, WTF::String>(WTF::String const&) const
8   0x1173ed12d WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::ASCIICaseInsensitiveHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::contains(WTF::String const&) const
9   0x1173ebc9d WTF::HashSet<WTF::String, WTF::ASCIICaseInsensitiveHash, WTF::HashTraits<WTF::String> >::contains(WTF::String const&) const
10  0x117767b49 WebCore::isRemoteWebArchive(WebCore::DocumentLoader const&)
11  0x11776735a WebCore::DocumentLoader::continueAfterContentPolicy(WebCore::PolicyAction)
12  0x117765aaa WebCore::DocumentLoader::responseReceived(WebCore::ResourceResponse const&)
13  0x11776272c WebCore::DocumentLoader::handleSubstituteDataLoadNow()
14  0x1177738a5 WTF::RunLoopTimer<WebCore::DocumentLoader>::fired()
15  0x114b6d8c1 WTF::timerFired(__CFRunLoopTimer*, void*)
16  0x7fff886e8d74 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
17  0x7fff886e89ff __CFRunLoopDoTimer
18  0x7fff886e855a __CFRunLoopDoTimers
19  0x7fff886dff81 __CFRunLoopRun
20  0x7fff886df514 CFRunLoopRunSpecific
21  0x7fff87c702ac RunCurrentEventLoopInMode
22  0x7fff87c700e1 ReceiveNextEventCommon
23  0x7fff87c6ff16 _BlockUntilNextEventMatchingListInModeWithFilter
24  0x7fff86272cc9 _DPSNextEvent
25  0x7fff869e9d04 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
26  0x7fff86267669 -[NSApplication run]
27  0x7fff86231f7f NSApplicationMain
28  0x7fff9dbb88b3 _xpc_objc_main
29  0x7fff9dbb72d0 xpc_main
30  0x10f15f18d main
31  0x7fff9d954255 start

Tests that timed out:
  WebKit2.PendingAPIRequestURL

[Alex Christensen]

http://trac.webkit.org/r207323

[Andy Estes]

(In reply to comment #14)
> http://trac.webkit.org/r207323

Thanks Alex!