Bug 162921 – Add support for KeyboardEvent.isComposing attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Add support for KeyboardEvent.isComposing attribute:
- https://www.w3.org/TR/uievents/#dom-keyboardevent-iscomposing
- https://www.w3.org/TR/uievents/#ref-for-dom-keyboardevent-iscomposing-3

[Chris Dumez]

Manual test app:
- https://jsfiddle.net/ay92sr08/8/

Tested with Chinese input method (Pinyin):
[Log] compositionstart (show, line 46)
[Log] keydown: n, isComposing: true (show, line 52)
[Log] keyup: n, isComposing: true (show, line 55)
[Log] keydown: i, isComposing: true (show, line 52)
[Log] keyup: i, isComposing: true (show, line 55)
[Log] compositionend (show, line 49)

[Chris Dumez]

Created attachment 290621 [details]
WIP patch

[Chris Dumez]

Created attachment 290623 [details]
WIP Patch

[Chris Dumez]

Updated manual test case:
https://jsfiddle.net/ay92sr08/9/

Result:
[Log] compositionstart (show, line 46)
[Log] compositionupdate (show, line 52, x2)
[Log] keydown: n, isComposing: true (show, line 55)
[Log] keyup: n, isComposing: true (show, line 58)
[Log] compositionupdate (show, line 52, x2)
[Log] keydown: i, isComposing: true (show, line 55)
[Log] keyup: i, isComposing: true (show, line 58)
[Log] compositionend (show, line 49)

[Chris Dumez]

Created attachment 290630 [details]
Patch

[Darin Adler]

Comment on attachment 290630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290630&action=review

> Source/WebCore/dom/KeyboardEvent.cpp:117
> +    , m_isComposing(view && view->frame() ? view->frame()->editor().hasComposition() : false)

I think you should just use another && here instead of using ? :

> Source/WebCore/dom/KeyboardEvent.h:130
> +    bool m_isComposing : 1;

Maybe the old bool item should be changed to not use bitfields instead?

[Chris Dumez]

Created attachment 290664 [details]
Patch

[Chris Dumez]

Created attachment 290667 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 290667 [details]
Patch

Clearing flags on attachment: 290667

Committed r206796: <http://trac.webkit.org/changeset/206796>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.