Bug 162916 - [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
Summary: [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 162544
  Show dependency tree / graph
 
Reported: 2016-10-04 10:21 PDT by Yusuke Suzuki
Modified: 2016-10-04 14:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (37.41 KB, patch)
2016-10-04 10:40 PDT, Yusuke Suzuki 		fpizlo: review+
Details | Formatted Diff | Diff
Patch for landing (44.93 KB, patch)
2016-10-04 11:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (47.42 KB, patch)
2016-10-04 11:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (48.08 KB, patch)
2016-10-04 12:04 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-10-04 10:21:19 PDT 
[DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
Comment 1 Yusuke Suzuki 2016-10-04 10:40:41 PDT 
Created attachment 290614 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-04 10:42:22 PDT 
Attachment 290614 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-10-04 11:02:04 PDT 
Comment on attachment 290614 [details]
Patch

This is awesome!  please make the bots happy. Hopefully it's not a serious bug.
Comment 4 Yusuke Suzuki 2016-10-04 11:10:29 PDT 
(In reply to comment #3)
> Comment on attachment 290614 [details]
> Patch
> 
> This is awesome!  please make the bots happy. Hopefully it's not a serious
> bug.

Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it includes DFGMinifiedID.h!). I'll soon fix this issue.
Comment 5 Filip Pizlo 2016-10-04 11:15:19 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 290614 [details]
> > Patch
> > 
> > This is awesome!  please make the bots happy. Hopefully it's not a serious
> > bug.
> 
> Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it
> includes DFGMinifiedID.h!). I'll soon fix this issue.

Crazy!  Maybe we can break the dependency on MinifiedID.  It doesn't seem to need it.
Comment 6 Filip Pizlo 2016-10-04 11:17:14 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Comment on attachment 290614 [details]
> > > Patch
> > > 
> > > This is awesome!  please make the bots happy. Hopefully it's not a serious
> > > bug.
> > 
> > Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it
> > includes DFGMinifiedID.h!). I'll soon fix this issue.
> 
> Crazy!  Maybe we can break the dependency on MinifiedID.  It doesn't seem to
> need it.

Actually, DFGMinifiedID.h only includes DFGCommon.h, which is already exportable, so I guess it wouldn't be the end of the world if DFGMinifiedID.h was also made exportable.
Comment 7 Yusuke Suzuki 2016-10-04 11:38:43 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #3)
> > > > Comment on attachment 290614 [details]
> > > > Patch
> > > > 
> > > > This is awesome!  please make the bots happy. Hopefully it's not a serious
> > > > bug.
> > > 
> > > Thanks! It seems that CCallHelpers is not export-to-WebCore ready (Oh, it
> > > includes DFGMinifiedID.h!). I'll soon fix this issue.
> > 
> > Crazy!  Maybe we can break the dependency on MinifiedID.  It doesn't seem to
> > need it.
> 
> Actually, DFGMinifiedID.h only includes DFGCommon.h, which is already
> exportable, so I guess it wouldn't be the end of the world if
> DFGMinifiedID.h was also made exportable.

OK, I've changed this attribute from Project to Private.
And I also fixed CMake issue. Before landing, I'll see the patch's health in EWS.
Comment 8 Yusuke Suzuki 2016-10-04 11:40:11 PDT 
Created attachment 290626 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2016-10-04 11:43:02 PDT 
Attachment 290626 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Yusuke Suzuki 2016-10-04 11:53:42 PDT 
Created attachment 290629 [details]
Patch for landing

Add more assembler/ headers. Some assembler/ headers were not included in any targets.
Comment 11 WebKit Commit Bot 2016-10-04 11:55:42 PDT 
Attachment 290629 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Yusuke Suzuki 2016-10-04 12:04:01 PDT 
Created attachment 290632 [details]
Patch for landing

Add more jit headers (generic data structures). Some assembler/ and jit/ headers were not included in any targets.
Comment 13 WebKit Commit Bot 2016-10-04 12:07:53 PDT 
Attachment 290632 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:46:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Yusuke Suzuki 2016-10-04 12:37:22 PDT 
Committed r206779: <http://trac.webkit.org/changeset/206779>