Bug 162914 - [GStreamer][EME] Utility function to create decryptor
Summary: [GStreamer][EME] Utility function to create decryptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords:
Depends on:
Blocks: 157314
  Show dependency tree / graph
 
Reported: 2016-10-04 10:12 PDT by Enrique Ocaña
Modified: 2016-10-26 01:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2016-10-04 10:15 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2016-10-16 12:09 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2016-10-26 01:23 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2016-10-04 10:12:38 PDT 
Add a utility function to find a suitable GStreamer decryptor element.
Comment 1 Enrique Ocaña 2016-10-04 10:15:38 PDT 
Created attachment 290610 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2016-10-08 07:49:34 PDT 
Comment on attachment 290610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290610&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:200
> +#if GST_CHECK_VERSION(1, 5, 3)

Let's flag this also with ENCRYPTED_MEDIA. Btw, add a comment about moving the version check from the code to the CMake part. EME needs that GStreamer version otherwise it won't function. But of course, we can do this in a follow up. You promise to do it or the guilt will chase until you die and even afterwards.

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:206
> +    GST_DEBUG("looking for decryptor for %s", protectionSystem);

GST_TRACE

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:215
> +            GstStaticPadTemplate* templ = static_cast<GstStaticPadTemplate*>(current->data);

Full name

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:216
> +            GstCaps* caps = gst_static_pad_template_get_caps(templ);

GRefPtr

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:217
> +            guint leng = gst_caps_get_size(caps);

Full name, type unsigned

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:220
> +            for (guint i = 0; !decryptor && i < leng; ++i) {

type unsigned

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:221
> +                GstStructure* st = gst_caps_get_structure(caps, i);

Full name
Comment 3 Enrique Ocaña 2016-10-16 12:09:52 PDT 
Created attachment 291769 [details]
Patch
Comment 4 Enrique Ocaña 2016-10-26 01:23:01 PDT 
Created attachment 292899 [details]
Patch
Comment 5 Enrique Ocaña 2016-10-26 01:48:09 PDT 
Comment on attachment 292899 [details]
Patch

Clearing flags on attachment: 292899

Committed r207886: <http://trac.webkit.org/changeset/207886>
Comment 6 Enrique Ocaña 2016-10-26 01:48:16 PDT 
All reviewed patches have been landed.  Closing bug.