Bug 162914 – [GStreamer][EME] Utility function to create decryptor

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Enrique Ocaña]

Add a utility function to find a suitable GStreamer decryptor element.

[Enrique Ocaña]

Created attachment 290610 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 290610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290610&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:200
> +#if GST_CHECK_VERSION(1, 5, 3)

Let's flag this also with ENCRYPTED_MEDIA. Btw, add a comment about moving the version check from the code to the CMake part. EME needs that GStreamer version otherwise it won't function. But of course, we can do this in a follow up. You promise to do it or the guilt will chase until you die and even afterwards.

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:206
> +    GST_DEBUG("looking for decryptor for %s", protectionSystem);

GST_TRACE

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:215
> +            GstStaticPadTemplate* templ = static_cast<GstStaticPadTemplate*>(current->data);

Full name

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:216
> +            GstCaps* caps = gst_static_pad_template_get_caps(templ);

GRefPtr

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:217
> +            guint leng = gst_caps_get_size(caps);

Full name, type unsigned

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:220
> +            for (guint i = 0; !decryptor && i < leng; ++i) {

type unsigned

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:221
> +                GstStructure* st = gst_caps_get_structure(caps, i);

Full name

[Enrique Ocaña]

Created attachment 291769 [details]
Patch

[Enrique Ocaña]

Created attachment 292899 [details]
Patch

[Enrique Ocaña]

Comment on attachment 292899 [details]
Patch

Clearing flags on attachment: 292899

Committed r207886: <http://trac.webkit.org/changeset/207886>

[Enrique Ocaña]

All reviewed patches have been landed.  Closing bug.