Bug 162911 - [GStreamer][MSE][EME] Remove MSE code from regular player and add EME support
Summary: [GStreamer][MSE][EME] Remove MSE code from regular player and add EME support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords:
Depends on:
Blocks: 157314
  Show dependency tree / graph
 
Reported: 2016-10-04 09:33 PDT by Enrique Ocaña
Modified: 2016-10-26 01:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (32.37 KB, patch)
2016-10-04 09:59 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (32.43 KB, patch)
2016-10-16 12:09 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (32.43 KB, patch)
2016-10-26 01:22 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2016-10-04 09:33:13 PDT 
Now that the MSE responsibility has been refactored to the dedicated MediaPlayerPrivateGStreamerMSE subclass, the regular player no longer needs the MSE code, just to expose some more methods to the subclass. Also, small changes to accomodate the EME support are needed.
Comment 1 Enrique Ocaña 2016-10-04 09:59:51 PDT 
Created attachment 290609 [details]
Patch
Comment 2 Enrique Ocaña 2016-10-04 10:07:07 PDT 
Comment on attachment 290609 [details]
Patch

Wait until all the patches in 157314 are ready.
Comment 3 Xabier Rodríguez Calvar 2016-10-08 07:23:19 PDT 
Comment on attachment 290609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290609&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:309
> +        auto mediaDuration = durationMediaTime();

Type this, please

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:625
> +    if (!m_pipeline || !m_source)

UNLIKELY?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:690
> +    if (!m_pipeline || !m_source)

UNLIKELY?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:743
> +    if (!m_pipeline || !m_source)

UNLIKELY?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1272
> +    if (!m_pipeline || !durationMediaTime() || (!isMediaSource() && !totalBytes()))

UNLIKELY?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1645
> +    auto now = currentMediaTime();

Type this, please
Comment 4 Enrique Ocaña 2016-10-16 12:09:19 PDT 
Created attachment 291768 [details]
Patch
Comment 5 Enrique Ocaña 2016-10-26 01:22:39 PDT 
Created attachment 292898 [details]
Patch
Comment 6 Enrique Ocaña 2016-10-26 01:47:35 PDT 
Comment on attachment 292898 [details]
Patch

Clearing flags on attachment: 292898

Committed r207885: <http://trac.webkit.org/changeset/207885>
Comment 7 Enrique Ocaña 2016-10-26 01:47:43 PDT 
All reviewed patches have been landed.  Closing bug.