Bug 162898 – [GStreamer][MSE] SourceBufferPrivateGStreamer refactoring

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Enrique Ocaña]

Move SourceBufferPrivateGStreamer to an mse directory and add unimplemented features (abort, enqueueing, sample flow control).

[Enrique Ocaña]

Created attachment 290590 [details]
Patch

[Enrique Ocaña]

Comment on attachment 290590 [details]
Patch

Wait until all the patches in 157314 are ready.

[Xabier Rodríguez Calvar]

Comment on attachment 290590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290590&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:89
> +    MediaSourceGStreamer* m_mediaSource;
> +    ContentType m_type;
> +    RefPtr<MediaSourceClientGStreamerMSE> m_client;
> +    SourceBufferPrivateClient* m_sourceBufferPrivateClient;

Let's add a comment here and create bug later to study making these plain pointers RefPtr or similar.

[Xabier Rodríguez Calvar]

(In reply to comment #3)
> Let's add a comment here and create bug later to study making these plain
> pointers RefPtr or similar.

After talking to Quique (Enrique) in person, we saw that there are cross references in place and we don't want to mess this up.

[Enrique Ocaña]

Created attachment 291761 [details]
Patch

[Zan Dobersek]

Comment on attachment 291761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291761&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:60
> +    , m_client(client)

It seems to be assumed that m_client is non-null throughout the lifetime of SourceBufferPrivateGStreamer, at least how it's used in append() and because it's not nulled out anywhere.

If that's the case, the parameter to this constructor and the member variables should be Ref<>, and there's no need to null-check it anywhere.

> Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:62
> +    , m_isReadyForMoreSamples(true)
> +    , m_notifyWhenReadyForMoreSamples(false)

These can be initialized in the constructor.

> Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:68
> +SourceBufferPrivateGStreamer::~SourceBufferPrivateGStreamer()
> +{
> +}

Default it.

[Enrique Ocaña]

Created attachment 292407 [details]
Patch

[Enrique Ocaña]

Created attachment 292780 [details]
Patch

[Enrique Ocaña]

Created attachment 292892 [details]
Patch

[Enrique Ocaña]

Comment on attachment 292892 [details]
Patch

Clearing flags on attachment: 292892

Committed r207879: <http://trac.webkit.org/changeset/207879>

[Enrique Ocaña]

All reviewed patches have been landed.  Closing bug.