Bug 162893 – [GStreamer] GStreamer Media Description

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Enrique Ocaña]

Implement the MediaDescription interface for the GStreamer platform.

[Enrique Ocaña]

Created attachment 290586 [details]
Patch

[Enrique Ocaña]

Comment on attachment 290586 [details]
Patch

Wait until all the patches in 157314 are ready.

[Enrique Ocaña]

Created attachment 291758 [details]
Patch

[Zan Dobersek]

Comment on attachment 291758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291758&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:49
> +    AtomicString simpleCodecName(codecName);
> +
> +    return simpleCodecName;

Just return `codecName`, it should be converted into AtomicString implicitly.

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:34
> +private:
> +    GRefPtr<GstCaps> m_caps;

The public section is always first here. This should be moved below where currently the constructor is.

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:39
> +    static PassRefPtr<GStreamerMediaDescription> create(GstCaps* caps)
> +    {
> +        return adoptRef(new GStreamerMediaDescription(caps));
> +    }

This should return Ref<GStreamerMediaDescription>.

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:41
> +    virtual ~GStreamerMediaDescription() { }

Default the constructor:

    virtual ~GStreamerMediaDescription() = default;

It should probably be placed in the implementation file.

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:53
> +    GStreamerMediaDescription(GstCaps* caps)
> +        : MediaDescription()
> +        , m_caps(caps)
> +    {
> +    }

This too could be moved into the implementation file. I don't think there's much profit in defining it in the header and having it inlined by the compiler.

[Enrique Ocaña]

Created attachment 292249 [details]
Patch

[Enrique Ocaña]

Created attachment 292404 [details]
Patch

[Enrique Ocaña]

Created attachment 292889 [details]
Patch

[Enrique Ocaña]

Comment on attachment 292889 [details]
Patch

Clearing flags on attachment: 292889

Committed r207876: <http://trac.webkit.org/changeset/207876>

[Enrique Ocaña]

All reviewed patches have been landed.  Closing bug.