Bug 162891 - [SOUP] Move request HTTP body handling to ResourceRequestSoup and simplify it
Summary: [SOUP] Move request HTTP body handling to ResourceRequestSoup and simplify it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on:
Blocks:
 
Reported: 2016-10-04 00:55 PDT by Carlos Garcia Campos
Modified: 2016-10-05 00:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.34 KB, patch)
2016-10-04 01:04 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-10-04 00:55:04 PDT 
We are currently adding the HTTP body to the message in ResourceHandleSoup, but we could do it as part of the ResourceRequest::updateSoupMessage() method, since the HTTP body is indeed part of the request.
Comment 1 Carlos Garcia Campos 2016-10-04 01:04:30 PDT 
Created attachment 290577 [details]
Patch
Comment 2 Alex Christensen 2016-10-04 08:06:38 PDT 
Comment on attachment 290577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290577&action=review

> Source/WebCore/platform/soup/SharedBufferSoup.cpp:43
> +    if (m_soupBuffer && !offset && !size) {

!size? Is this correct?
Comment 3 Carlos Garcia Campos 2016-10-04 08:33:31 PDT 
Comment on attachment 290577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290577&action=review

>> Source/WebCore/platform/soup/SharedBufferSoup.cpp:43
>> +    if (m_soupBuffer && !offset && !size) {
> 
> !size? Is this correct?

Yes, it means this was called with no arguments, and then we just take a return a reference.
Comment 4 Carlos Garcia Campos 2016-10-05 00:11:16 PDT 
Committed r206805: <http://trac.webkit.org/changeset/206805>