Bug 162880 - Add Display P3 ColorSpace
Summary: Add Display P3 ColorSpace
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 162998
Blocks:
  Show dependency tree / graph
 
Reported: 2016-10-03 15:23 PDT by Dean Jackson
Modified: 2016-10-05 23:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2016-10-03 15:28 PDT, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
Patch (32.46 KB, text/plain)
2016-10-03 15:39 PDT, Dean Jackson 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-10-03 15:23:30 PDT 
Add Display P3 ColorSpace
Comment 1 Radar WebKit Bug Importer 2016-10-03 15:24:27 PDT 
<rdar://problem/28598564>
Comment 2 Dean Jackson 2016-10-03 15:28:05 PDT 
Created attachment 290528 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-10-03 15:30:51 PDT 
Comment on attachment 290528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290528&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:100
> +    static CGColorSpaceRef displayP3Space = deviceRGBColorSpaceRef();

Do we really want to use device here, or fall back to sRGB?
Comment 4 Dean Jackson 2016-10-03 15:39:54 PDT 
Created attachment 290529 [details]
Patch
Comment 5 Dean Jackson 2016-10-05 22:18:49 PDT 
Committed r206845: <http://trac.webkit.org/changeset/206845>
Comment 6 Csaba Osztrogonác 2016-10-05 23:06:41 PDT 
(In reply to comment #5)
> Committed r206845: <http://trac.webkit.org/changeset/206845>

It broke the El Capitan build,see build.webkit.org for details.
Comment 7 WebKit Commit Bot 2016-10-05 23:53:37 PDT 
Re-opened since this is blocked by bug 162998