Bug 162873 - Missing include in MediaDescription
Summary: Missing include in MediaDescription
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
Depends on:
Blocks: 157314
  Show dependency treegraph
Reported: 2016-10-03 11:46 PDT by Enrique Ocaña
Modified: 2016-10-08 04:57 PDT (History)
2 users (show)

See Also:

Patch (1.11 KB, patch)
2016-10-03 11:49 PDT, Enrique Ocaña
no flags Details | Formatted Diff | Diff
Patch (1.13 KB, patch)
2016-10-04 02:57 PDT, Enrique Ocaña
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2016-10-03 11:46:21 PDT
Build fails when MediaDesciption.h is included in a file with no other dependencies which already require the AtomicString header.
Comment 1 Enrique Ocaña 2016-10-03 11:49:14 PDT
Created attachment 290498 [details]
Comment 2 Alex Christensen 2016-10-03 14:13:19 PDT
Comment on attachment 290498 [details]

Actually, does <wtf/Forward.h> work?
Comment 3 Enrique Ocaña 2016-10-04 02:57:09 PDT
Created attachment 290585 [details]
Comment 4 Enrique Ocaña 2016-10-04 02:58:36 PDT
Yes, Forward.h works at the expense of having to include the AtomicString header in the final cpp file. It seems a good compromise.
Comment 5 Xabier Rodríguez Calvar 2016-10-04 06:35:47 PDT
Comment on attachment 290585 [details]

For this you wouldn't even need to upload the patch for review. It could be an unreviewed build fix.
Comment 6 Xabier Rodríguez Calvar 2016-10-04 06:36:34 PDT
And it is something you can land now, no need to wait for other MSE changes.
Comment 7 WebKit Commit Bot 2016-10-08 04:57:22 PDT
Comment on attachment 290585 [details]

Clearing flags on attachment: 290585

Committed r206952: <http://trac.webkit.org/changeset/206952>
Comment 8 WebKit Commit Bot 2016-10-08 04:57:26 PDT
All reviewed patches have been landed.  Closing bug.