Bug 162857 - Remove FetchBody::m_isEmpty
Summary: Remove FetchBody::m_isEmpty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-02 05:49 PDT by youenn fablet
Modified: 2016-10-03 10:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (31.29 KB, patch)
2016-10-02 05:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-02 05:49:36 PDT
Following on bug 162841, we should remove m_isEmpty and handle null bodies at FetchBodyOwner level.
Comment 1 youenn fablet 2016-10-02 05:57:39 PDT
Created attachment 290467 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-03 09:31:28 PDT
Attachment 290467 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/fetch/FetchBody.h:91:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:92:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:93:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:94:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:95:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:96:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/fetch/FetchBody.h:97:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 7 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-10-03 10:59:54 PDT
Comment on attachment 290467 [details]
Patch

Clearing flags on attachment: 290467

Committed r206737: <http://trac.webkit.org/changeset/206737>
Comment 4 WebKit Commit Bot 2016-10-03 10:59:59 PDT
All reviewed patches have been landed.  Closing bug.