Bug 162855 - Add support for KeyboardEvent.getModifierState() operation
Summary: Add support for KeyboardEvent.getModifierState() operation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://w3c.github.io/uievents/#dom-k...
Keywords: WebExposed
: 40999 (view as bug list)
Depends on:
Blocks: 162852 162861
  Show dependency tree / graph
 
Reported: 2016-10-01 20:37 PDT by Chris Dumez
Modified: 2016-10-02 15:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.00 KB, patch)
2016-10-02 12:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-01 20:37:09 PDT 
Add support for KeyboardEvent.getModifierState() operation:
- https://w3c.github.io/uievents/#dom-keyboardevent-getmodifierstate
Comment 1 Chris Rebert 2016-10-01 20:51:20 PDT 
*** Bug 40999 has been marked as a duplicate of this bug. ***
Comment 2 Chris Dumez 2016-10-02 12:39:43 PDT 
Created attachment 290473 [details]
Patch
Comment 3 Darin Adler 2016-10-02 14:18:17 PDT 
I’m kind of surprised we still had this function sitting around, almost unused but nt quite. Seems like the modifier name is kind of like an enumeration. Surprising that the specification just does it as a string rather than using an enumeration.

As a side note, the only existing caller of the getModifierState function, the handleKeyboardSelectionMovement function in EventHandler.cpp, should *not* be using it. It should just be calling the different boolean functions directly.
Comment 4 Chris Dumez 2016-10-02 14:52:11 PDT 
Comment on attachment 290473 [details]
Patch

Clearing flags on attachment: 290473

Committed r206725: <http://trac.webkit.org/changeset/206725>
Comment 5 Chris Dumez 2016-10-02 14:52:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Rebert 2016-10-02 15:07:56 PDT 
Is there a follow-up bug for support of the remaining modifiers which are listed as TODO in the commit?
Comment 7 Chris Dumez 2016-10-02 15:11:56 PDT 
(In reply to comment #6)
> Is there a follow-up bug for support of the remaining modifiers which are
> listed as TODO in the commit?

Not yet, I'll file one soon.