Add support for KeyboardEvent.getModifierState() operation:
*** Bug 40999 has been marked as a duplicate of this bug. ***
Created attachment 290473 [details]
I’m kind of surprised we still had this function sitting around, almost unused but nt quite. Seems like the modifier name is kind of like an enumeration. Surprising that the specification just does it as a string rather than using an enumeration.
As a side note, the only existing caller of the getModifierState function, the handleKeyboardSelectionMovement function in EventHandler.cpp, should *not* be using it. It should just be calling the different boolean functions directly.
Comment on attachment 290473 [details]
Clearing flags on attachment: 290473
Committed r206725: <http://trac.webkit.org/changeset/206725>
All reviewed patches have been landed. Closing bug.
Is there a follow-up bug for support of the remaining modifiers which are listed as TODO in the commit?
(In reply to comment #6)
> Is there a follow-up bug for support of the remaining modifiers which are
> listed as TODO in the commit?
Not yet, I'll file one soon.