Bug 162854 - Add support for KeyboardEvent.repeat attribute
Summary: Add support for KeyboardEvent.repeat attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://w3c.github.io/uievents/#dom-k...
Keywords: WebExposed
Depends on:
Blocks: 162852
  Show dependency tree / graph
 
Reported: 2016-10-01 20:35 PDT by Chris Dumez
Modified: 2019-06-14 04:40 PDT (History)
13 users (show)

See Also:

Attachments
Patch (6.72 KB, patch)
2016-10-02 11:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-01 20:35:59 PDT 
Add support for KeyboardEvent.repeat attribute:
- https://w3c.github.io/uievents/#dom-keyboardevent-repeat
Comment 1 Chris Dumez 2016-10-02 11:58:19 PDT 
Created attachment 290472 [details]
Patch
Comment 2 Darin Adler 2016-10-02 14:13:21 PDT 
Comment on attachment 290472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290472&action=review

> Source/WebCore/dom/KeyboardEvent.cpp:109
> +    , m_repeat(key.isAutoRepeat())

There are no tests that cover this code path.
Comment 3 WebKit Commit Bot 2016-10-02 14:35:54 PDT 
Comment on attachment 290472 [details]
Patch

Clearing flags on attachment: 290472

Committed r206724: <http://trac.webkit.org/changeset/206724>
Comment 4 WebKit Commit Bot 2016-10-02 14:35:58 PDT 
All reviewed patches have been landed.  Closing bug.