Bug 162850 - Web Inspector: Exception thrown when hovering network waterfall graphs during reload
Summary: Web Inspector: Exception thrown when hovering network waterfall graphs during...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-01 18:07 PDT by Matt Baker
Modified: 2016-10-02 14:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2016-10-01 18:12 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-10-01 18:07:45 PDT 
Summary:
Exception thrown when hovering network waterfall graphs during reload.

Steps to Reproduce:
1. Goto Network tab, reload inspected page
2. Hover over a record bar element in the grid
3. ⌘R to reload inspected page, while moving cursor in and out of the graph element
  => TypeError:​ null is not an object (evaluating 'this.dataGrid')​ (at ResourceTimelineDataGridNode.js:​377:​26)​

Note:
The record bar's mouseleave event listener doesn't check that the node's grid reference is valid before using it. The node's grid reference is set to null when a node is removed from the grid, but before it's removed from the DOM. This occurs during page load as resources are reordered in the grid.
Comment 1 Radar WebKit Bug Importer 2016-10-01 18:07:56 PDT 
<rdar://problem/28579653>
Comment 2 Matt Baker 2016-10-01 18:12:19 PDT 
Created attachment 290457 [details]
Patch
Comment 3 BJ Burg 2016-10-02 13:40:29 PDT 
Comment on attachment 290457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290457&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:12
> +        (WebInspector.ResourceTimelineDataGridNode):

This line seems unnecessary.
Comment 4 WebKit Commit Bot 2016-10-02 14:01:32 PDT 
Comment on attachment 290457 [details]
Patch

Clearing flags on attachment: 290457

Committed r206722: <http://trac.webkit.org/changeset/206722>
Comment 5 WebKit Commit Bot 2016-10-02 14:01:35 PDT 
All reviewed patches have been landed.  Closing bug.