Bug 162838 - [ES6] GeneratorFunction constructor should instantiate generator function
Summary: [ES6] GeneratorFunction constructor should instantiate generator function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-30 23:57 PDT by Yusuke Suzuki
Modified: 2016-10-01 16:37 PDT (History)
9 users (show)

See Also:


Attachments
Patch (10.67 KB, patch)
2016-09-30 23:59 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (14.34 KB, patch)
2016-10-01 00:39 PDT, Yusuke Suzuki
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-09-30 23:57:22 PDT
[ES6] GeneratorFunction constructor should instantiate generator function
Comment 1 Yusuke Suzuki 2016-09-30 23:59:14 PDT
Created attachment 290431 [details]
Patch
Comment 2 Yusuke Suzuki 2016-10-01 00:39:16 PDT
Created attachment 290433 [details]
Patch
Comment 3 Yusuke Suzuki 2016-10-01 00:39:49 PDT
OK, ready.
Comment 4 Saam Barati 2016-10-01 16:05:20 PDT
Comment on attachment 290433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290433&action=review

r=me

> Source/JavaScriptCore/ChangeLog:15
> +        2. Pass newTarget ins GeneratorFunction constructor to make it subclassible

s/ins/into
Comment 5 Yusuke Suzuki 2016-10-01 16:36:04 PDT
Comment on attachment 290433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290433&action=review

>> Source/JavaScriptCore/ChangeLog:15
>> +        2. Pass newTarget ins GeneratorFunction constructor to make it subclassible
> 
> s/ins/into

Ooops! Thanks.
Comment 6 Yusuke Suzuki 2016-10-01 16:37:46 PDT
Committed r206710: <http://trac.webkit.org/changeset/206710>