Bug 162837 – Use the preferred style of RefCounted<ClipRects>()

• Status: RESOLVED
• Resolution: INVALID
• Component: Layout and Rendering

[zalan]

diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
index 0c4d1bf..5039236 100644
--- a/Source/WebCore/rendering/RenderLayer.cpp
+++ b/Source/WebCore/rendering/RenderLayer.cpp
@@ -198,7 +198,7 @@ private:
     }
 
     ClipRects(const ClipRects& other)
-        : RefCounted()
+        : RefCounted<ClipRects>()
         , m_fixed(other.fixed())
         , m_overflowClipRect(other.overflowClipRect())
         , m_fixedClipRect(other.fixedClipRect())

[zalan]

Created attachment 290423 [details]
Patch

[Alex Christensen]

Comment on attachment 290423 [details]
Patch

r=me
Please also do this in StyleScrollSnapPoints.cpp, MediaList.cpp, and twice in MediaStreamTrackPrivate.cpp

[Alexey Proskuryakov]

Is there a written rule stating that this is the preferred style? I think that the normal style is to omit the initializer.

[Simon Fraser (smfr)]

Comment on attachment 290423 [details]
Patch

I agree with ap.

[Simon Fraser (smfr)]

You still need to remove the : RefCounted()

[Alexey Proskuryakov]

Not sure if we want to support compiling with -Wextra, looks like this enables warnings that don't make sense.

[Darin Adler]

Comment on attachment 290423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290423&action=review

> Source/WebCore/ChangeLog:3
> +        Use the preferred style of RefCounted<ClipRects>()

Why is this preferred style?

[Simon Fraser (smfr)]

What is the preferred style? And why can't we just give RefCounted its own copy constructor?