Bug 162833 – [MultiCol] Render tree should be all clean by the end of FrameView::layout().

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

We fail to clean all the renderers while running the following test:
LayoutTests/imported/blink/fast/multicol/dynamic/multicol-with-abspos-svg-with-foreignobject-with-multicol-crash.html

[zalan]

LayoutTests/fast/inline/quotation-text-changes-dynamically.html

[zalan]

LayoutTests/fast/css/content/quote-crash-when-floating.html

[zalan]

(In reply to comment #0)
> We fail to clean all the renderers while running the following test:
> LayoutTests/imported/blink/fast/multicol/dynamic/multicol-with-abspos-svg-
> with-foreignobject-with-multicol-crash.html
Fixed by http://trac.webkit.org/changeset/208661

[zalan]

Created attachment 294800 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 294800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:172
> +    RenderTreeInternalMutationScope reparentingIsOn(view());

Do you really want this scope to last until the end of the function?

[Simon Fraser (smfr)]

Comment on attachment 294800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review

> Source/WebCore/rendering/RenderView.h:206
> +    bool renderTreeIsBeingMutatedInternally() const { return !!m_renderTreeInternalMutationCounter; }

No need for !! (C++ converts non-0 to true for you).

[zalan]

Comment on attachment 294800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294800&action=review

>> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:172
>> +    RenderTreeInternalMutationScope reparentingIsOn(view());
> 
> Do you really want this scope to last until the end of the function?

I do. While spanner removal probably won't impact the RenderQuote use case, it is still part of internal render tree mutation and in the future we might need to bail out in some other functions to avoid (similar) unintended changes.

[WebKit Commit Bot]

Comment on attachment 294800 [details]
Patch

Clearing flags on attachment: 294800

Committed r208731: <http://trac.webkit.org/changeset/208731>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.