Bug 162807 - Fix modules tests after r206653 handle breakpoint locations in import/export statements
Summary: Fix modules tests after r206653 handle breakpoint locations in import/export ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-30 14:00 PDT by Joseph Pecoraro
Modified: 2016-09-30 14:28 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.14 KB, patch)
2016-09-30 14:02 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-30 14:00:51 PDT 
Summary:
Fix modules tests after r206653 handle breakpoint locations in import/export statements

Steps to Reproduce:
1. $ run-jsc-stress-tests --release JSTests/modules.yaml
  => Failures

Notes:
- RELEASE_ASSERT that contents of import/export statement need debug hooks
- Only affects modules
Comment 1 Joseph Pecoraro 2016-09-30 14:02:36 PDT 
Created attachment 290380 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-09-30 14:25:01 PDT 
Comment on attachment 290380 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=290380&action=review

> Source/JavaScriptCore/parser/ASTBuilder.h:756
> +        // The export statement itself will get the breakpoint location, don't record another for the declaration statement.
> +        declaration->setNeedsDebugHook();

Mark reviewed this in person. He recommended clarifying this comment.
Comment 3 Joseph Pecoraro 2016-09-30 14:28:17 PDT 
https://trac.webkit.org/changeset/206671