Bug 162802 - Web Inspector: Stepping over/out of a function sometimes resumes instead of taking you to caller
Summary: Web Inspector: Stepping over/out of a function sometimes resumes instead of t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-30 12:32 PDT by Joseph Pecoraro
Modified: 2016-09-30 16:31 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.94 KB, patch)
2016-09-30 12:34 PDT, Joseph Pecoraro 		mark.lam: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (With Test) (9.49 KB, patch)
2016-09-30 16:24 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-30 12:32:10 PDT 
Summary:
Stepping over/out of a function sometimes resumes instead of taking you to caller

Steps to Reproduce:
1. Inspect http://bogojoker.com/shell
2. Set a breakpoint of "if (autoplay)" line in easySlider.min.js
3. Trigger breakpoint by clicking down arrow on page
4. Step Out
  => Expected to pause in caller, did not

Notes:
- Step-out reproduces the issue
- Step-over (at the end of the function) reproduces the issue
- Step-in (at the end of the function) DOES NOT reproduce the issue, it behaves as expected
Comment 1 Radar WebKit Bug Importer 2016-09-30 12:32:27 PDT 
<rdar://problem/28569982>
Comment 2 Joseph Pecoraro 2016-09-30 12:34:12 PDT 
Created attachment 290364 [details]
[PATCH] Proposed Fix
Comment 3 Mark Lam 2016-09-30 12:54:26 PDT 
Comment on attachment 290364 [details]
[PATCH] Proposed Fix

r=me.  I'll come take a look at the original test case with you.
Comment 4 Joseph Pecoraro 2016-09-30 16:22:06 PDT 
Comment on attachment 290364 [details]
[PATCH] Proposed Fix

Thanks to Mark I was able to add a test case.
Comment 5 Joseph Pecoraro 2016-09-30 16:24:56 PDT 
Created attachment 290404 [details]
[PATCH] For Landing (With Test)
Comment 6 Joseph Pecoraro 2016-09-30 16:25:34 PDT 
Comment on attachment 290404 [details]
[PATCH] For Landing (With Test)

View in context: https://bugs.webkit.org/attachment.cgi?id=290404&action=review

> LayoutTests/inspector/debugger/stepping/stepping-pause-in-inner-step-to-parent.html:6
> +<button id="button">Click</button>

Err, I can remove this button! Will land manually.
Comment 7 Joseph Pecoraro 2016-09-30 16:31:16 PDT 
<https://trac.webkit.org/changeset/206693>