Bug 162797 - Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied().
Summary: Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-09-30 11:32 PDT by Mark Lam
Modified: 2016-09-30 12:50 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch. (1.84 KB, patch)
2016-09-30 11:36 PDT, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-09-30 11:32:30 PDT
This is because the RELEASE_ASSERT() that follows immediately after will also dump the stack back trace.  Hence, the first dump will be redundant.
Comment 1 Mark Lam 2016-09-30 11:36:00 PDT
Created attachment 290356 [details]
proposed patch.
Comment 2 Geoffrey Garen 2016-09-30 12:47:23 PDT
Comment on attachment 290356 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2016-09-30 12:50:59 PDT
Thanks for the review.  Landed in r206658: <http://trac.webkit.org/r206658>.