Bug 162793 - Use topVMEntryFrame to determine whether to skip the re-throw of a simulated throw.
Summary: Use topVMEntryFrame to determine whether to skip the re-throw of a simulated ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-09-30 10:44 PDT by Mark Lam
Modified: 2016-09-30 11:18 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch. (2.23 KB, patch)
2016-09-30 10:48 PDT, Mark Lam
mark.lam: review-
Details | Formatted Diff | Diff
proposed patch. (2.32 KB, patch)
2016-09-30 10:51 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-09-30 10:44:34 PDT
Change the ThrowScope destructor to use topVMEntryFrame (instead of topCallFrame) in the determination of whether to skip the re-throw of a simulated throw.  This is needed because the topCallFrame is not updated in operationConstructArityCheck(), whereas topVMEntryFrame is always updated properly.  Hence, we should just switch to using the more reliable topVMEntryFrame instead.
Comment 1 Mark Lam 2016-09-30 10:48:57 PDT
Created attachment 290348 [details]
proposed patch.
Comment 2 Mark Lam 2016-09-30 10:49:24 PDT
Comment on attachment 290348 [details]
proposed patch.

Need to fix the comment.
Comment 3 Mark Lam 2016-09-30 10:51:25 PDT
Created attachment 290349 [details]
proposed patch.
Comment 4 Saam Barati 2016-09-30 11:02:15 PDT
Comment on attachment 290349 [details]
proposed patch.

r=me
Comment 5 Mark Lam 2016-09-30 11:18:43 PDT
Thanks for the review.  Landed in r206643: <http://trac.webkit.org/r206643>.