Bug 162792 – Inspector exception in `parseTextForRule()` when pasting into CSS rule selector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Rob Brackett]

-------
Inspected URL:        http://localhost:8000/guides/anchor/index.html
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/603.1.8+ (KHTML, like Gecko)

Uncaught Exceptions:
 - TypeError: null is not an object (evaluating 'parseTextForRule(data)') (at CSSStyleDeclarationSection.js:437:49)
    _handleSelectorPaste @ CSSStyleDeclarationSection.js:437:49
    _handleSelectorPaste @ [native code]
-------

* STEPS TO REPRODUCE
1. In the Elements panel, select an element with several CSS rules applying to it
2. In the Styles sidebar, select part of the selector for one of the rules and copy it (via keyboard, cmd+c)
3. Paste (via keyboard, cmd+v) the selected text at the start of a different selector
4. Inspector immediately flips to the "Web Inspector encountered an internal error" screen

[Devin Rousso]

Created attachment 290463 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/28580248>

[Matt Baker]

I can't reproduce this with the steps provided. Devin, do you have a reduction?

[Devin Rousso]

(In reply to comment #3)
> I can't reproduce this with the steps provided. Devin, do you have a
> reduction?

The reproduction works just fine for me.  Either way, the logic still doesn't work correctly with strings that contain newlines.

[Matt Baker]

Comment on attachment 290463 [details]
Patch

Was able to repro, r=me.

[WebKit Commit Bot]

Comment on attachment 290463 [details]
Patch

Clearing flags on attachment: 290463

Committed r206888: <http://trac.webkit.org/changeset/206888>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.