Created attachment 290319 [details] Patch Implement animation of font-variation-settings
Created attachment 290398 [details] Patch
Comment on attachment 290398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290398&action=review > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385 > + if (fromItem.tag() != toItem.tag()) > + return FontVariationSettings(); Is tag order meaningful? If not, I wonder if we should match ignoring order.
(In reply to comment #2) > Comment on attachment 290398 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290398&action=review > > > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385 > > + if (fromItem.tag() != toItem.tag()) > > + return FontVariationSettings(); > > Is tag order meaningful? If not, I wonder if we should match ignoring order. Order isn't meaningful, but the items in the array are already in sorted order (see FontVariationSettings::insert() to see the search for the correct index). Because this list will always be small, I opted for a simple flat array instead of a more complicated tree data structure.
Committed r206690: <http://trac.webkit.org/changeset/206690>