Bug 162783 - Implement animation of font-variation-settings
Summary: Implement animation of font-variation-settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 162490
  Show dependency treegraph
 
Reported: 2016-09-30 03:20 PDT by Myles C. Maxfield
Modified: 2016-09-30 16:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (14.87 KB, patch)
2016-09-30 03:20 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (18.47 KB, patch)
2016-09-30 15:15 PDT, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-09-30 03:20:36 PDT
Created attachment 290319 [details]
Patch

Implement animation of font-variation-settings
Comment 1 Myles C. Maxfield 2016-09-30 15:15:26 PDT
Created attachment 290398 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-09-30 15:43:21 PDT
Comment on attachment 290398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290398&action=review

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385
> +        if (fromItem.tag() != toItem.tag())
> +            return FontVariationSettings();

Is tag order meaningful? If not, I wonder if we should match ignoring order.
Comment 3 Myles C. Maxfield 2016-09-30 15:48:18 PDT
(In reply to comment #2)
> Comment on attachment 290398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290398&action=review
> 
> > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385
> > +        if (fromItem.tag() != toItem.tag())
> > +            return FontVariationSettings();
> 
> Is tag order meaningful? If not, I wonder if we should match ignoring order.

Order isn't meaningful, but the items in the array are already in sorted order (see FontVariationSettings::insert() to see the search for the correct index). Because this list will always be small, I opted for a simple flat array instead of a more complicated tree data structure.
Comment 4 Myles C. Maxfield 2016-09-30 16:10:27 PDT
Committed r206690: <http://trac.webkit.org/changeset/206690>