RESOLVED FIXED Bug 162783
Implement animation of font-variation-settings 
https://bugs.webkit.org/show_bug.cgi?id=162783
Summary Implement animation of font-variation-settings
Myles C. Maxfield
Reported 2016-09-30 03:20:36 PDT
Created attachment 290319 [details] Patch Implement animation of font-variation-settings
Attachments
Patch (14.87 KB, patch)
2016-09-30 03:20 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (18.47 KB, patch)
2016-09-30 15:15 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-09-30 15:15:26 PDT
Created attachment 290398 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-09-30 15:43:21 PDT
Comment on attachment 290398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290398&action=review > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385 > + if (fromItem.tag() != toItem.tag()) > + return FontVariationSettings(); Is tag order meaningful? If not, I wonder if we should match ignoring order.
Myles C. Maxfield
Comment 3 2016-09-30 15:48:18 PDT
(In reply to comment #2) > Comment on attachment 290398 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290398&action=review > > > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:385 > > + if (fromItem.tag() != toItem.tag()) > > + return FontVariationSettings(); > > Is tag order meaningful? If not, I wonder if we should match ignoring order. Order isn't meaningful, but the items in the array are already in sorted order (see FontVariationSettings::insert() to see the search for the correct index). Because this list will always be small, I opted for a simple flat array instead of a more complicated tree data structure.
Myles C. Maxfield
Comment 4 2016-09-30 16:10:27 PDT
Committed r206690: <http://trac.webkit.org/changeset/206690>
Note You need to log in before you can comment on or make changes to this bug.