Bug 162782 - Implement rendering of font-variation-settings
Summary: Implement rendering of font-variation-settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 162490
  Show dependency tree / graph
 
Reported: 2016-09-30 03:19 PDT by Myles C. Maxfield
Modified: 2017-02-10 01:48 PST (History)
9 users (show)

See Also:

Attachments
Patch (20.45 KB, patch)
2016-09-30 03:19 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (24.69 KB, patch)
2016-09-30 15:06 PDT, Myles C. Maxfield 		zalan: review+
Details | Formatted Diff | Diff
Patch for re-landing (24.71 KB, patch)
2016-10-03 02:33 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-09-30 03:19:20 PDT 
Implement rendering of font-variation-settings
Comment 1 Myles C. Maxfield 2016-09-30 03:19:41 PDT 
Created attachment 290318 [details]
Patch
Comment 2 Myles C. Maxfield 2016-09-30 15:06:28 PDT 
Created attachment 290392 [details]
Patch
Comment 3 Myles C. Maxfield 2016-09-30 16:14:48 PDT 
Committed r206692: <http://trac.webkit.org/changeset/206692>
Comment 4 Chris Dumez 2016-10-02 11:21:34 PDT 
Reverted r206692 and r206718 for reason:

Seems to have caused >200 failures on Sierra

Committed r206719: <http://trac.webkit.org/changeset/206719>
Comment 5 Ryan Haddad 2016-10-02 12:29:17 PDT 
(In reply to comment #4)
> Reverted r206692 and r206718 for reason:
> 
> Seems to have caused >200 failures on Sierra
> 
> Committed r206719: <http://trac.webkit.org/changeset/206719>

Example of failures:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/256
Comment 6 Myles C. Maxfield 2016-10-03 02:33:04 PDT 
Created attachment 290481 [details]
Patch for re-landing
Comment 7 WebKit Commit Bot 2016-10-03 14:36:42 PDT 
Comment on attachment 290481 [details]
Patch for re-landing

Rejecting attachment 290481 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 290481, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2213220
Comment 8 Myles C. Maxfield 2016-10-03 17:08:54 PDT 
Committed r206761: <http://trac.webkit.org/changeset/206761>
Comment 9 Radar WebKit Bug Importer 2017-02-10 01:48:31 PST 
<rdar://problem/30461633>