Fix fast/text/trak-optimizeLegibility.html

[Myles C. Maxfield]

Fix fast/text/trak-optimizeLegibility.html

[Myles C. Maxfield]

Created attachment 290314 [details]
Patch

[Build Bot]

Comment on attachment 290314 [details]
Patch

Attachment 290314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2174607

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html

[Build Bot]

Created attachment 290327 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

Comment on attachment 290314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290314&action=review

> Source/WebCore/ChangeLog:8
> +        Somehow this test got rebaselined to allow an unnecessary delta

"Somehow" is a bit vague given that we can consult SVN.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:667
> +    if ((!family.length() || family[0] != '.') && whitelist.size() && !whitelist.contains(family))

I would prefer family[0] != '.' to be wrapped in a small function called isSystemFont() or something. Do we do this check anywhere else?

[Myles C. Maxfield]

Created attachment 290371 [details]
Patch

[Myles C. Maxfield]

Committed r206666: <http://trac.webkit.org/changeset/206666>