Bug 162778 - Remove "rem" unit optimization for document element font size changes
Summary: Remove "rem" unit optimization for document element font size changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-30 03:06 PDT by Antti Koivisto
Modified: 2016-09-30 10:02 PDT (History)
3 users (show)

See Also:

Attachments
patch (8.88 KB, patch)
2016-09-30 03:16 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.31 MB, application/zip)
2016-09-30 04:14 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-09-30 03:06:36 PDT 
We track from the parser level if any stylesheet in a document uses any rem units. This is only used to minimally optimize a case where document element's (<html>) font size changes dynamically. In practice such changes are rare.
Comment 1 Antti Koivisto 2016-09-30 03:16:34 PDT 
Created attachment 290316 [details]
patch
Comment 2 Build Bot 2016-09-30 04:14:07 PDT 
Comment on attachment 290316 [details]
patch

Attachment 290316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2174390

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html
Comment 3 Build Bot 2016-09-30 04:14:10 PDT 
Created attachment 290324 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 WebKit Commit Bot 2016-09-30 10:02:45 PDT 
Comment on attachment 290316 [details]
patch

Clearing flags on attachment: 290316

Committed r206641: <http://trac.webkit.org/changeset/206641>
Comment 5 WebKit Commit Bot 2016-09-30 10:02:48 PDT 
All reviewed patches have been landed.  Closing bug.