Bug 162766 - Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
Summary: Media controls are displayed in the incorrect state momentarily after switchi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-29 19:03 PDT by Wenson Hsieh
Modified: 2016-10-22 00:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.38 KB, patch)
2016-09-29 20:09 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (28.02 KB, patch)
2016-10-02 00:05 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Set Now Playing visibility after setting up info dictionary. (22.95 KB, patch)
2016-10-03 20:56 PDT, Wenson Hsieh 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing (22.92 KB, patch)
2016-10-04 08:03 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-09-29 19:03:37 PDT 
Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
Comment 1 Wenson Hsieh 2016-09-29 20:09:10 PDT 
Created attachment 290287 [details]
Patch
Comment 2 Wenson Hsieh 2016-09-29 20:10:00 PDT 
<rdar://problem/28533523>
Comment 3 Wenson Hsieh 2016-10-02 00:05:10 PDT 
Created attachment 290466 [details]
Patch
Comment 4 Wenson Hsieh 2016-10-03 20:56:07 PDT 
Created attachment 290561 [details]
Set Now Playing visibility after setting up info dictionary.
Comment 5 Jer Noble 2016-10-03 22:17:55 PDT 
Comment on attachment 290561 [details]
Set Now Playing visibility after setting up info dictionary.

View in context: https://bugs.webkit.org/attachment.cgi?id=290561&action=review

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:205
>  #endif
> +
> +    if (canLoad_MediaRemote_MRMediaRemoteSetNowPlayingVisibility())
> +        MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), MRNowPlayingClientVisibilityAlwaysVisible);

I think you need this just on the other side of the #endif.  r=me with that fix.
Comment 6 Wenson Hsieh 2016-10-04 07:26:24 PDT 
Comment on attachment 290561 [details]
Set Now Playing visibility after setting up info dictionary.

View in context: https://bugs.webkit.org/attachment.cgi?id=290561&action=review

>> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:205
>> +        MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), MRNowPlayingClientVisibilityAlwaysVisible);
> 
> I think you need this just on the other side of the #endif.  r=me with that fix.

Ah, that's right -- fixed. Good catch!
Comment 7 Wenson Hsieh 2016-10-04 08:03:12 PDT 
Created attachment 290602 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-10-04 08:37:58 PDT 
Comment on attachment 290602 [details]
Patch for landing

Clearing flags on attachment: 290602

Committed r206771: <http://trac.webkit.org/changeset/206771>