Update Touch constructor test to cover clientX / clientY attributes.
Created attachment 290249 [details] Patch
Committed r206619: <http://trac.webkit.org/changeset/206619>
Comment on attachment 290249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290249&action=review > LayoutTests/fast/events/touch/touch-constructor.html:48 > + if (init.hasOwnProperty("clientX")) Looks like there was just a typo above - screenX is tested 3 times, 2 of those were probably supposed to be changed to be clientX and clientY. > LayoutTests/fast/events/touch/touch-constructor.html:71 > +shouldNotThrow("touch = new Touch({ identifier: 1, target: document.body, clientX: 1.5, clientY: 2.5, screenX: 3.5, screenY: 4.5, pageX: 5.5, pageY: 6.5, force: 7.5, clientX: 8.5, clientY: 9.5 })"); clientX and clientY were already in the dictionary here and below.
Also, in case there is some confusion here - my comment in https://bugs.webkit.org/show_bug.cgi?id=147740#c11 was about Safari's non-standard (and not well documented) TouchEvent.clientX/TouchEvent.clientY properties. clientX/clientY on _Touch_ (in contrast) makes perfect sense, already works and is standardized.
(In reply to comment #3) > Comment on attachment 290249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290249&action=review > > > LayoutTests/fast/events/touch/touch-constructor.html:48 > > + if (init.hasOwnProperty("clientX")) > > Looks like there was just a typo above - screenX is tested 3 times, 2 of > those were probably supposed to be changed to be clientX and clientY. > > > LayoutTests/fast/events/touch/touch-constructor.html:71 > > +shouldNotThrow("touch = new Touch({ identifier: 1, target: document.body, clientX: 1.5, clientY: 2.5, screenX: 3.5, screenY: 4.5, pageX: 5.5, pageY: 6.5, force: 7.5, clientX: 8.5, clientY: 9.5 })"); > > clientX and clientY were already in the dictionary here and below. Thanks for pointing this out. I'll fix the test.