Bug 162749 - Air should be able to replace constant materializations with adds
Summary: Air should be able to replace constant materializations with adds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 14:03 PDT by Filip Pizlo
Modified: 2016-10-11 14:36 PDT (History)
5 users (show)

See Also:

Attachments
the patch (2.14 KB, patch)
2016-09-29 14:03 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (3.12 KB, patch)
2016-10-10 20:00 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (4.50 KB, patch)
2016-10-10 20:15 PDT, Filip Pizlo 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-09-29 14:03:13 PDT 
We thought this was a good idea for a long time but then we got evidence that it's not a good idea.  In the meantime, I implemented it.  I will use this bug to stash the code and report any results.
Comment 1 Filip Pizlo 2016-09-29 14:03:49 PDT 
Created attachment 290241 [details]
the patch

This turns out to be very easy to write.
Comment 2 Filip Pizlo 2016-10-10 20:00:25 PDT 
Created attachment 291216 [details]
the patch
Comment 3 Filip Pizlo 2016-10-10 20:15:25 PDT 
Created attachment 291218 [details]
the patch
Comment 4 Yusuke Suzuki 2016-10-11 13:47:39 PDT 
Comment on attachment 291218 [details]
the patch

r=me
Comment 5 Filip Pizlo 2016-10-11 13:54:47 PDT 
Landed in https://trac.webkit.org/changeset/207164
Comment 6 Saam Barati 2016-10-11 14:36:41 PDT 
Comment on attachment 291218 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291218&action=review

> Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp:195
> +        // First handle some special instructions.

Nit: I don't think this comment really adds anything.

> Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp:210
> +                    // should add fancier materializations here for ARM if the BigImm is yuge.

s/yuge/huge

Maybe open a bug for this?