Bug 162743 - Break some slow running tests into smaller bits so they don't time out.
Summary: Break some slow running tests into smaller bits so they don't time out.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 160384
  Show dependency treegraph
 
Reported: 2016-09-29 12:02 PDT by Mark Lam
Modified: 2016-09-29 12:14 PDT (History)
0 users

See Also:


Attachments
proposed patch. (48.98 KB, patch)
2016-09-29 12:06 PDT, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-09-29 12:02:46 PDT
The following tests have shown to be slow running:
    op_div.js
    op_lshift.js
    op_mod.js
    op_mul.js
    op_rshift.js
    op_sub.js
    op_urshift

These tests auto-generate permutations of values to apply to binary operations.  They also test the operations with 3 permutations of value types:
    1. VarVar - both operands variables
    2. VarConst - variable operand 1, constant / literal operand 2
    3. ConstVar - constant / literal operand 1, variable operand 2

We can prevent these tests from timing out by breaking each up to only run 1 of the 3 permutations of value types.
Comment 1 Mark Lam 2016-09-29 12:06:15 PDT
Created attachment 290230 [details]
proposed patch.
Comment 2 Keith Miller 2016-09-29 12:10:47 PDT
Comment on attachment 290230 [details]
proposed patch.

r=me.
Comment 3 Mark Lam 2016-09-29 12:14:08 PDT
Thanks for the review.  Landed in r206600: <http://trac.webkit.org/r206600>.