WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162743
Break some slow running tests into smaller bits so they don't time out.
https://bugs.webkit.org/show_bug.cgi?id=162743
Summary
Break some slow running tests into smaller bits so they don't time out.
Mark Lam
Reported
2016-09-29 12:02:46 PDT
The following tests have shown to be slow running: op_div.js op_lshift.js op_mod.js op_mul.js op_rshift.js op_sub.js op_urshift These tests auto-generate permutations of values to apply to binary operations. They also test the operations with 3 permutations of value types: 1. VarVar - both operands variables 2. VarConst - variable operand 1, constant / literal operand 2 3. ConstVar - constant / literal operand 1, variable operand 2 We can prevent these tests from timing out by breaking each up to only run 1 of the 3 permutations of value types.
Attachments
proposed patch.
(48.98 KB, patch)
2016-09-29 12:06 PDT
,
Mark Lam
keith_miller
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2016-09-29 12:06:15 PDT
Created
attachment 290230
[details]
proposed patch.
Keith Miller
Comment 2
2016-09-29 12:10:47 PDT
Comment on
attachment 290230
[details]
proposed patch. r=me.
Mark Lam
Comment 3
2016-09-29 12:14:08 PDT
Thanks for the review. Landed in
r206600
: <
http://trac.webkit.org/r206600
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug