Bug 162738 - parser-syntax-check should display the output of syntax errors
Summary: parser-syntax-check should display the output of syntax errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 10:53 PDT by Saam Barati
Modified: 2016-09-29 11:47 PDT (History)
12 users (show)

See Also:


Attachments
patch (197.56 KB, patch)
2016-09-29 11:28 PDT, Saam Barati
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-09-29 10:53:53 PDT
...
Comment 1 Saam Barati 2016-09-29 11:28:51 PDT
Created attachment 290223 [details]
patch
Comment 2 Joseph Pecoraro 2016-09-29 11:33:47 PDT
Comment on attachment 290223 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290223&action=review

r=me!

> LayoutTests/js/parser-syntax-check-expected.txt:92
> +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator."

Some, like this one and others, end in a period and many others don't. A good follow-up would make them all consistent.
Comment 3 Saam Barati 2016-09-29 11:45:06 PDT
(In reply to comment #2)
> Comment on attachment 290223 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290223&action=review
> 
> r=me!
> 
> > LayoutTests/js/parser-syntax-check-expected.txt:92
> > +PASS Invalid: "function f() { a ? b }". Produced the following syntax error: "SyntaxError: Unexpected token '}'. Expected ':' in ternary operator."
> 
> Some, like this one and others, end in a period and many others don't. A
> good follow-up would make them all consistent.

Indeed. Opened:
https://bugs.webkit.org/show_bug.cgi?id=162742
Comment 4 Saam Barati 2016-09-29 11:47:43 PDT
landed in:
https://trac.webkit.org/changeset/206594