WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
162737
[Win] Don't hardcode the name of the system font
https://bugs.webkit.org/show_bug.cgi?id=162737
Summary
[Win] Don't hardcode the name of the system font
Brent Fulgham
Reported
2016-09-29 10:46:47 PDT
WebKit hard-codes the name of the Windows system font in a few places. This isn't right for a number of reasons, not the least of which is that "Lucida Grande" isn't even the system font anymore!
> + m_isSystemFont = !wcscmp(faceName, L"Lucida Grande");
This should be done in one place (shared between all Windows ports), and should be done properly to reflect the actual font used on the system (which may change from time-to-time).
Attachments
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2016-10-04 00:11:03 PDT
Is there API to get this? I thought the new system font was Segoe UI?
Brent Fulgham
Comment 2
2016-10-04 11:03:24 PDT
(In reply to
comment #1
)
> Is there API to get this? > > I thought the new system font was Segoe UI?
Correct! I'll look into this. I'm poking around other Font stuff in Windows, so this will naturally fall out from there.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug