Bug 162737 - [Win] Don't hardcode the name of the system font
Summary: [Win] Don't hardcode the name of the system font
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 10:46 PDT by Brent Fulgham
Modified: 2016-10-04 11:03 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-09-29 10:46:47 PDT 
WebKit hard-codes the name of the Windows system font in a few places. This isn't right for a number of reasons, not the least of which is that "Lucida Grande" isn't even the system font anymore!

> +        m_isSystemFont = !wcscmp(faceName, L"Lucida Grande");

This should be done in one place (shared between all Windows ports), and should be done properly to reflect the actual font used on the system (which may change from time-to-time).
Comment 1 Myles C. Maxfield 2016-10-04 00:11:03 PDT 
Is there API to get this?

I thought the new system font was Segoe UI?
Comment 2 Brent Fulgham 2016-10-04 11:03:24 PDT 
(In reply to comment #1)
> Is there API to get this?
> 
> I thought the new system font was Segoe UI?

Correct!

I'll look into this. I'm poking around other Font stuff in Windows, so this will naturally fall out from there.