Bug 162734 – Bindings do not throw a TypeError if a required dictionary member is missing

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Bindings do not throw a TypeError if a required dictionary member is missing.

For example, if there is a "required long id" member in a dictionary, and it is missing. Our bindings will currently pass 0 to the implementation instead of throwing a TypeError.

[Chris Dumez]

Relevant spec:
https://heycam.github.io/webidl/#es-dictionary

[Chris Dumez]

I am working on fixing this.

[Chris Dumez]

Created attachment 290501 [details]
Patch

[Darin Adler]

Comment on attachment 290501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290501&action=review

> Source/WebCore/ChangeLog:17
> +        except for the support for dictionary inheritence that is still missing

spelling error: inheritance

[Build Bot]

Comment on attachment 290501 [details]
Patch

Attachment 290501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2212487

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290505 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290501 [details]
Patch

Attachment 290501 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2212578

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290507 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290501 [details]
Patch

Attachment 290501 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2212576

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290508 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 290512 [details]
Patch

[Chris Dumez]

Created attachment 290516 [details]
Patch

[Geoffrey Garen]

Comment on attachment 290516 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 290516 [details]
Patch

Clearing flags on attachment: 290516

Committed r206766: <http://trac.webkit.org/changeset/206766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.