WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 162733
Make WKTR short timeout dynamic
https://bugs.webkit.org/show_bug.cgi?id=162733
Summary
Make WKTR short timeout dynamic
Alexey Proskuryakov
Reported
2016-09-29 10:12:36 PDT
WebKitTestRunner has a hardcoded value for how long to wait for IPC responses, which is 5 seconds, or 10 seconds under ASan. But some of the operations can be fairly time consuming - e.g. launching Networking process on demand. These may take longer under load, especially with GuardMalloc. I think that half of the normal test timeout would work here. It will be a little weird because those are per-test ("slow" tests get more), and IPC timeouts don't need to be, but that seems harmless. See also:
rdar://problem/28116746
Attachments
proposed patch
(5.85 KB, patch)
2016-09-29 10:21 PDT
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2016-09-29 10:21:16 PDT
Created
attachment 290213
[details]
proposed patch
WebKit Commit Bot
Comment 2
2016-09-29 11:47:21 PDT
Comment on
attachment 290213
[details]
proposed patch Clearing flags on attachment: 290213 Committed
r206596
: <
http://trac.webkit.org/changeset/206596
>
WebKit Commit Bot
Comment 3
2016-09-29 11:47:25 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug