Bug 162731 - Remove addSubresourceStyleURLs functions
Summary: Remove addSubresourceStyleURLs functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 09:52 PDT by Antti Koivisto
Modified: 2016-09-29 12:39 PDT (History)
3 users (show)

See Also:


Attachments
patch (16.59 KB, patch)
2016-09-29 10:06 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (16.63 KB, patch)
2016-09-29 10:22 PDT, Antti Koivisto
rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (939.25 KB, application/zip)
2016-09-29 11:36 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-09-29 09:52:47 PDT
They can be replaced with calls to the modern traverseSubresources functions.
Comment 1 Antti Koivisto 2016-09-29 10:06:12 PDT
Created attachment 290210 [details]
patch
Comment 2 WebKit Commit Bot 2016-09-29 10:08:46 PDT
Attachment 290210 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/StyledElement.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2016-09-29 10:22:01 PDT
Created attachment 290214 [details]
patch
Comment 4 Build Bot 2016-09-29 11:36:51 PDT
Comment on attachment 290214 [details]
patch

Attachment 290214 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2169557

New failing tests:
fast/images/pdf-as-image-with-annotations.html
Comment 5 Build Bot 2016-09-29 11:36:54 PDT
Created attachment 290224 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Antti Koivisto 2016-09-29 12:39:42 PDT
https://trac.webkit.org/r206603