Bug 162707 - check-webkit-style: Enable the legal/copyright rule for cpp/h files
Summary: check-webkit-style: Enable the legal/copyright rule for cpp/h files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-28 17:19 PDT by Joseph Pecoraro
Modified: 2016-10-06 20:29 PDT (History)
3 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.14 KB, patch)
2016-09-28 17:20 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-28 17:19:59 PDT
check-webkit-style: Enable the legal/copyright rule for cpp/h files

Not sure why this is not enabled by default. It seems completely reasonable to me.

It isn't working right now because it outputs for "line 0" but that will be fixed in bug 159785.

Seems we can just enable it!
Comment 1 Joseph Pecoraro 2016-09-28 17:20:52 PDT
Created attachment 290150 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-10-06 20:29:00 PDT
Comment on attachment 290150 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 290150

Committed r206898: <http://trac.webkit.org/changeset/206898>
Comment 3 WebKit Commit Bot 2016-10-06 20:29:03 PDT
All reviewed patches have been landed.  Closing bug.