Bug 162678 – woff2 upgrade introduces compiler warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Please fix compiler warnings before submitting patches! It seems unlikely that your compiler didn't warn about these:

[22/78] Building CXX object Source/Thi...MakeFiles/woff2.dir/src/woff2_dec.cc.o
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::ReadWOFF2Header(const uint8_t*, size_t, woff2::{anonymous}::WOFF2Header*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1140:12: warning: unused variable ‘dst_offset’ [-Wunused-variable]
   uint64_t dst_offset = first_table_offset;
            ^~~~~~~~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::WriteHeaders(const uint8_t*, size_t, woff2::{anonymous}::RebuildMetadata*, woff2::{anonymous}::WOFF2Header*, woff2::WOFF2Out*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:34: warning: unused parameter ‘data’ [-Wunused-parameter]
 bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
                                  ^~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:47: warning: unused parameter ‘length’ [-Wunused-parameter]
 bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
                                               ^~~~~~

[Michael Catanzaro]

Created attachment 290085 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 290085 [details]
Patch

Clearing flags on attachment: 290085

Committed r206532: <http://trac.webkit.org/changeset/206532>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Konstantin Tokarev]

Comment on attachment 290085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290085&action=review

> Source/ThirdParty/woff2/CMakeLists.txt:22
> +    ADD_TARGET_PROPERTIES(woff2 COMPILE_FLAGS "-Wno-sign-compare -Wunused-variable -Wunused-parameter")

I think you've meant -Wno-unused-variable -Wno-unused-parameter

[Konstantin Tokarev]

Committed r206535: <http://trac.webkit.org/changeset/206535>

[Michael Catanzaro]

Sigh, thanks... I guess I must not have tested it at all....