Bug 162670 - [Win] Compile fix.
Summary: [Win] Compile fix.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-28 04:36 PDT by Per Arne Vollan
Modified: 2016-09-28 09:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2016-09-28 04:46 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-09-28 04:36:05 PDT
There are currently some compile errors on Windows:

C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(109): error C2953: 'JSC::GCIncomingRefCounted': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(42): note: see declaration of 'JSC::GCIncomingRefCounted' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp)
Comment 1 Per Arne Vollan 2016-09-28 04:46:32 PDT
Created attachment 290074 [details]
Patch
Comment 2 Brent Fulgham 2016-09-28 07:09:04 PDT
Comment on attachment 290074 [details]
Patch

R=me
Comment 3 Per Arne Vollan 2016-09-28 09:29:50 PDT
(In reply to comment #2)
> Comment on attachment 290074 [details]
> Patch
> 
> R=me

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2016-09-28 09:32:39 PDT
Comment on attachment 290074 [details]
Patch

Clearing flags on attachment: 290074

Committed r206521: <http://trac.webkit.org/changeset/206521>
Comment 5 WebKit Commit Bot 2016-09-28 09:32:42 PDT
All reviewed patches have been landed.  Closing bug.