WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162670
[Win] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=162670
Summary
[Win] Compile fix.
Per Arne Vollan
Reported
2016-09-28 04:36:05 PDT
There are currently some compile errors on Windows: C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(109): error C2953: 'JSC::GCIncomingRefCounted': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(42): note: see declaration of 'JSC::GCIncomingRefCounted' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp)
Attachments
Patch
(1.80 KB, patch)
2016-09-28 04:46 PDT
,
Per Arne Vollan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2016-09-28 04:46:32 PDT
Created
attachment 290074
[details]
Patch
Brent Fulgham
Comment 2
2016-09-28 07:09:04 PDT
Comment on
attachment 290074
[details]
Patch R=me
Per Arne Vollan
Comment 3
2016-09-28 09:29:50 PDT
(In reply to
comment #2
)
> Comment on
attachment 290074
[details]
> Patch > > R=me
Thanks for reviewing!
WebKit Commit Bot
Comment 4
2016-09-28 09:32:39 PDT
Comment on
attachment 290074
[details]
Patch Clearing flags on attachment: 290074 Committed
r206521
: <
http://trac.webkit.org/changeset/206521
>
WebKit Commit Bot
Comment 5
2016-09-28 09:32:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug