Bug 162668 - WOFF2 test woff2-totalsfntsize fails
Summary: WOFF2 test woff2-totalsfntsize fails
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://test.csswg.org/harness/test/wo...
Keywords: InRadar
Depends on: 162608
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-28 03:29 PDT by Frédéric Wang (:fredw)
Modified: 2024-03-28 17:13 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-09-28 03:29:09 PDT
This is handled in bug 162608 for ports using the WOFF2 copy bundled in WebKit, but other ports must ensure that a recent version of WOFF2 is used.
Comment 1 Frédéric Wang (:fredw) 2017-10-30 08:08:36 PDT
The port with a test expectations are Mac, iOS and Win: 

fred@igalia-fwang:~/webkit/WebKit/LayoutTests$ find -type f -name TestExpectations | xargs grep woff2-totalsfntsize
./platform/mac/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ ImageOnlyFailure ]
./platform/win/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ Skip ]
./platform/ios/TestExpectations:webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ Skip ]
Comment 2 Myles C. Maxfield 2017-10-31 13:36:25 PDT
We have fast/text/resources/ahem.woff2, does this font work instead?
Comment 3 Frédéric Wang (:fredw) 2017-10-31 13:44:29 PDT
(In reply to Myles C. Maxfield from comment #2)
> We have fast/text/resources/ahem.woff2, does this font work instead?

Mmh, I'm not sure I understand your suggestion. The purpose of this test is to check

https://www.w3.org/TR/WOFF2/#conform-mustNotRejectIncorrectTotalSize

so we need a specific font to verify the conformance, right?

BTW I think the test is actually http://www.w3c-test.org/css/WOFF2/header-totalsfntsize-001.xht ; so maybe we can remove the current files and import https://github.com/w3c/web-platform-tests/blob/master/css/WOFF2/header-totalsfntsize-001.xht instead.
Comment 4 Myles C. Maxfield 2017-10-31 13:50:22 PDT
Oh, whoops, please disregard my comment. Sorry for the noise.
Comment 5 Frédéric Wang (:fredw) 2017-10-31 14:18:08 PDT
OK. Tomorrow I'll open a separate bug to import https://github.com/w3c/web-platform-tests/tree/master/css/WOFF2 anyway, as it seems we don't have them yet.
Comment 6 Radar WebKit Bug Importer 2024-03-28 16:57:05 PDT
<rdar://problem/125586567>
Comment 7 Ben Schwartz 2024-03-28 17:07:04 PDT
The expectations for Mac and iOS are outdated. Removing.
Comment 8 EWS 2024-03-28 17:13:58 PDT
Test gardening commit 276814@main (93124ab0fb4c): <https://commits.webkit.org/276814@main>

Reviewed commits have been landed. Closing PR #26592 and removing active labels.