Bug 162660 – Enable URLParser by default

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Enable URLParser by default

[Alex Christensen]

Created attachment 290426 [details]
Patch

[Alex Christensen]

Comment on attachment 290426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290426&action=review

> LayoutTests/fast/url/relative-expected.txt:10
> -PASS canonicalize('') is 'http://foo/bar'
> -PASS canonicalize('') is 'http://foo/bar'
> +FAIL canonicalize('') should be http://foo/bar. Was http://foo/bar#ref.
> +FAIL canonicalize('') should be http://foo/bar. Was http://foo/bar#.

I'm not 100% sure about these two, but the rest are good.

[Build Bot]

Comment on attachment 290426 [details]
Patch

Attachment 290426 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2180712

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290427 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290426 [details]
Patch

Attachment 290426 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2180713

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290428 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290426 [details]
Patch

Attachment 290426 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2180711

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290430 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290426 [details]
Patch

Attachment 290426 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2180727

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290432 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Comment on attachment 290426 [details]
Patch

Those two are wrong.  Not quite ready.  But now I have a list of changes from EWS!

[Alex Christensen]

Created attachment 290549 [details]
Patch

[Build Bot]

Comment on attachment 290549 [details]
Patch

Attachment 290549 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2214502

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290554 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290549 [details]
Patch

Attachment 290549 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2214510

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290555 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290549 [details]
Patch

Attachment 290549 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2214543

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290557 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290549 [details]
Patch

Attachment 290549 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2214562

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290560 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Michael Catanzaro]

Comment on attachment 290549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290549&action=review

> Source/WebCore/platform/URLParser.cpp:2715
> -static bool urlParserEnabled = false;
> +static bool urlParserEnabled = true;

When is it disabled?

[Alex Christensen]

Created attachment 290830 [details]
Patch

[Alex Christensen]

(In reply to comment #21)
> Comment on attachment 290549 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290549&action=review
> 
> > Source/WebCore/platform/URLParser.cpp:2715
> > -static bool urlParserEnabled = false;
> > +static bool urlParserEnabled = true;
> 
> When is it disabled?
It isn't.  I call URLParser::setEnabled in platformInitializeWebKit2 so we can change it at runtime, but hopefully that'll be temporary and I'll migrate everything to use the new URLParser and get rid of the old one.

[Build Bot]

Comment on attachment 290830 [details]
Patch

Attachment 290830 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2232627

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290841 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290830 [details]
Patch

Attachment 290830 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2232674

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm
security/block-test.html
http/tests/misc/url-in-utf32le.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/failure.html
storage/websql/open-database-expand-quota.html
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
http/tests/misc/url-in-utf16be.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/data-url-encoding-html.html
storage/websql/open-database-creation-callback.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/data-url-encoding-svg.html
http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1.html
fast/loader/file-URL-with-port-number.html
fast/url/ipv6.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/url-parse-1.html
http/tests/misc/url-in-utf32be.html
http/tests/misc/url-in-utf16le.html

[Build Bot]

Created attachment 290843 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290830 [details]
Patch

Attachment 290830 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2232681

New failing tests:
http/tests/contentextensions/make-https.html
security/block-test.html
fast/url/ipv6.html
fast/loader/window-open-to-invalid-url-disallowed.html
storage/websql/open-database-expand-quota.html
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
http/tests/misc/url-in-utf16be.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/url-parse-1.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/url-in-utf16le.html
http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1.html
fast/loader/file-URL-with-port-number.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/failure.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 290845 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290830 [details]
Patch

Attachment 290830 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2232732

New failing tests:
security/block-test.html
fast/url/ipv6.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/failure.html
storage/websql/open-database-expand-quota.html
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
http/tests/misc/url-in-utf16be.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/url-parse-1.html
http/tests/misc/url-in-utf32le.html
http/tests/quicklook/secure-document-with-subresources.html
http/tests/misc/url-in-utf16le.html
http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1.html
fast/loader/file-URL-with-port-number.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 290848 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Ok, enough of this EWS abuse.  I'll actually run all the tests on a reliable computer.

[Alex Christensen]

Created attachment 290948 [details]
Patch

[Build Bot]

Comment on attachment 290948 [details]
Patch

Attachment 290948 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2238944

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 290952 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290948 [details]
Patch

Attachment 290948 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2239072

New failing tests:
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/file-URL-with-port-number.html

[Build Bot]

Created attachment 290953 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290948 [details]
Patch

Attachment 290948 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2239054

New failing tests:
security/block-test.html
fast/loader/window-open-to-invalid-url-disallowed.html
http/tests/quicklook/secure-document-with-subresources.html
fast/loader/file-URL-with-port-number.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html

[Build Bot]

Created attachment 290955 [details]
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 290948 [details]
Patch

Attachment 290948 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2239161

New failing tests:
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/data-url-encoding-html.html
storage/websql/open-database-creation-callback.html
fast/loader/data-url-encoding-svg.html
fast/loader/file-URL-with-port-number.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm

[Build Bot]

Created attachment 290958 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Created attachment 290959 [details]
Patch

[Build Bot]

Comment on attachment 290959 [details]
Patch

Attachment 290959 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2239505

New failing tests:
fast/loader/window-open-to-invalid-url-disallowed.html
storage/websql/open-database-expand-quota.html
fast/loader/data-url-encoding-svg.html
fast/loader/data-url-encoding-html.html
storage/websql/open-database-creation-callback.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm

[Build Bot]

Created attachment 290964 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290959 [details]
Patch

Attachment 290959 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2239512

New failing tests:
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 290965 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290959 [details]
Patch

Attachment 290959 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2239523

New failing tests:
security/block-test.html
http/tests/quicklook/secure-document-with-subresources.html
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 290967 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 290959 [details]
Patch

Attachment 290959 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2239551

New failing tests:
fast/loader/window-open-to-invalid-url-disallowed.html
storage/websql/open-database-expand-quota.html
fast/loader/data-url-encoding-svg.html
fast/loader/data-url-encoding-html.html
storage/websql/open-database-creation-callback.html
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm

[Build Bot]

Created attachment 290968 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Created attachment 290989 [details]
Patch

[Build Bot]

Comment on attachment 290989 [details]
Patch

Attachment 290989 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2240763

New failing tests:
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 290995 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290989 [details]
Patch

Attachment 290989 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2240768

New failing tests:
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 290997 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290989 [details]
Patch

Attachment 290989 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2240817

New failing tests:
http/tests/quicklook/secure-document-with-subresources.html
security/block-test.html
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 291000 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 290989 [details]
Patch

Attachment 290989 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2241412

New failing tests:
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
storage/websql/open-database-expand-quota.html

[Build Bot]

Created attachment 291009 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Created attachment 291168 [details]
Patch

[Alex Christensen]

Created attachment 291181 [details]
Patch

[Alex Christensen]

Comment on attachment 291181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291181&action=review

> LayoutTests/ChangeLog:120
> +        * platform/mac/security/block-test-expected.txt:

Looks like I need to update security/block-test-expected.txt similarly to fix iOS.

> LayoutTests/TestExpectations:168
> +webkit.org/b/163127 storage/websql/open-database-creation-callback.html [ Skip ]
> +webkit.org/b/163127 storage/websql/open-database-expand-quota.html [ Skip ]

These two were fixed by https://trac.webkit.org/changeset/207033

[Alex Christensen]

Created attachment 291195 [details]
Patch

[Build Bot]

Comment on attachment 291195 [details]
Patch

Attachment 291195 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2259031

New failing tests:
http/tests/quicklook/secure-document-with-subresources.html

[Build Bot]

Created attachment 291205 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 291212 [details]
Patch

[Build Bot]

Comment on attachment 291212 [details]
Patch

Attachment 291212 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2259664

New failing tests:
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
security/block-test.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm

[Build Bot]

Created attachment 291219 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291212 [details]
Patch

Attachment 291212 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2259679

New failing tests:
security/block-test.html

[Build Bot]

Created attachment 291220 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291212 [details]
Patch

Attachment 291212 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2259666

New failing tests:
security/block-test.html

[Build Bot]

Created attachment 291221 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 291212 [details]
Patch

Attachment 291212 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2259682

New failing tests:
fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
security/block-test.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm

[Build Bot]

Created attachment 291222 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Created attachment 291226 [details]
Patch

[Alex Christensen]

Created attachment 291291 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/changeset/207162

[Alex Christensen]

Followup for an API test in http://trac.webkit.org/changeset/207167

[Alex Christensen]

And http://trac.webkit.org/changeset/207177

[Alex Christensen]

And http://trac.webkit.org/changeset/207184

[Alex Christensen]

*** Bug 55683 has been marked as a duplicate of this bug. ***

[Alex Christensen]

*** Bug 165597 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/64135483>