Bug 162658 – Adopt MediaRemote SPI to achieve desired Now Playing behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wenson Hsieh]

Adopt MediaRemote SPI to achieve desired Now Playing behavior

[Wenson Hsieh]

<rdar://problem/28499358>

[Wenson Hsieh]

Created attachment 290053 [details]
Patch

[Wenson Hsieh]

Created attachment 290054 [details]
Rebased on ToT

[Wenson Hsieh]

Comment on attachment 290054 [details]
Rebased on ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=290054&action=review

> Source/WebCore/ChangeLog:27
> [phone]  Wenson Hsieh  <[e-mail]>

This ChangeLog entry is from an earlier entry and was erroneously included in this patch. I will remove this.

[Wenson Hsieh]

Created attachment 290055 [details]
Fix TestWebKitAPI build on iOS and public SDKs.

[Jer Noble]

Comment on attachment 290055 [details]
Fix TestWebKitAPI build on iOS and public SDKs.

View in context: https://bugs.webkit.org/attachment.cgi?id=290055&action=review

r=me, with nits.

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:133
> +            MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), 3 /* MRNowPlayingClientVisibilityNeverVisible */);

These enums should be added to MediaRemoteSPI.h.

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:154
> +    MRMediaRemoteSetNowPlayingVisibility(MRMediaRemoteGetLocalOrigin(), 1 /* MRNowPlayingClientVisibilityAlwaysVisible */);

Ditto.

[Wenson Hsieh]

Created attachment 290098 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 290098 [details]
Patch for landing

Rejecting attachment 290098 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 290098, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2162576

[Wenson Hsieh]

Created attachment 290099 [details]
Patch for landing

[Wenson Hsieh]

Committed r206527: <http://trac.webkit.org/changeset/206527>

[Wenson Hsieh]

The layout test failure from commit queue does not seem related.