Bug 162649 - NetworkLoad and PingLoad should use private inheritance
Summary: NetworkLoad and PingLoad should use private inheritance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 17:40 PDT by Daniel Bates
Modified: 2016-09-27 18:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.93 KB, patch)
2016-09-27 17:57 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-09-27 17:40:48 PDT
It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient. Currently they publicly inherit from ResourceHandleClient.
Comment 1 Daniel Bates 2016-09-27 17:42:21 PDT
(In reply to comment #0)
> It is sufficient to have NetworkLoad and PingLoad privately inherit from
> ResourceHandleClient.

This should read:

It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient and NetworkDataTaskClient, respectively.
Comment 2 Daniel Bates 2016-09-27 17:57:14 PDT
Created attachment 290039 [details]
Patch
Comment 3 Daniel Bates 2016-09-27 18:03:50 PDT
Comment on attachment 290039 [details]
Patch

Clearing flags on attachment: 290039

Committed r206479: <http://trac.webkit.org/changeset/206479>
Comment 4 Daniel Bates 2016-09-27 18:03:54 PDT
All reviewed patches have been landed.  Closing bug.