WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162649
NetworkLoad and PingLoad should use private inheritance
https://bugs.webkit.org/show_bug.cgi?id=162649
Summary
NetworkLoad and PingLoad should use private inheritance
Daniel Bates
Reported
2016-09-27 17:40:48 PDT
It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient. Currently they publicly inherit from ResourceHandleClient.
Attachments
Patch
(6.93 KB, patch)
2016-09-27 17:57 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2016-09-27 17:42:21 PDT
(In reply to
comment #0
)
> It is sufficient to have NetworkLoad and PingLoad privately inherit from > ResourceHandleClient.
This should read: It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient and NetworkDataTaskClient, respectively.
Daniel Bates
Comment 2
2016-09-27 17:57:14 PDT
Created
attachment 290039
[details]
Patch
Daniel Bates
Comment 3
2016-09-27 18:03:50 PDT
Comment on
attachment 290039
[details]
Patch Clearing flags on attachment: 290039 Committed
r206479
: <
http://trac.webkit.org/changeset/206479
>
Daniel Bates
Comment 4
2016-09-27 18:03:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug