Bug 162643 – Use Color references where possible

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Use Color references where possible

[Radar WebKit Bug Importer]

<rdar://problem/28506550>

[Dean Jackson]

Created attachment 290021 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 290021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290021&action=review

> Source/WebCore/platform/graphics/GraphicsContext.cpp:920
> +    const Color& oldFillColor = fillColor();

Don't you actually need to make a copy here?

> Source/WebCore/rendering/style/RenderStyle.cpp:1210
> +const Color& RenderStyle::color() const
> +{
> +    return inherited->color;
> +}
> +
> +const Color& RenderStyle::visitedLinkColor() const
> +{
> +    return inherited->visitedLinkColor;
> +}
> +
> +void RenderStyle::setColor(const Color& v)
> +{
> +    SET_VAR(inherited, color, v);
> +}
> +
> +void RenderStyle::setVisitedLinkColor(const Color& v)
> +{
> +    SET_VAR(inherited, visitedLinkColor, v);
> +}

Not sure why you unwrapped these.

[Dean Jackson]

Comment on attachment 290021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290021&action=review

>> Source/WebCore/platform/graphics/GraphicsContext.cpp:920
>> +    const Color& oldFillColor = fillColor();
> 
> Don't you actually need to make a copy here?

Yep. Good catch.

>> Source/WebCore/rendering/style/RenderStyle.cpp:1210
>> +}
> 
> Not sure why you unwrapped these.

Because it was ugly.

[Build Bot]

Comment on attachment 290021 [details]
Patch

Attachment 290021 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2158007

New failing tests:
fast/text/empty-shadow.html

[Build Bot]

Created attachment 290035 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290021 [details]
Patch

Attachment 290021 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2158020

New failing tests:
fast/text/empty-shadow.html

[Build Bot]

Created attachment 290036 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290021 [details]
Patch

Attachment 290021 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2158015

New failing tests:
fast/text/empty-shadow.html

[Build Bot]

Created attachment 290038 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290021 [details]
Patch

Attachment 290021 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2158027

New failing tests:
fast/text/empty-shadow.html

[Build Bot]

Created attachment 290041 [details]
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Dean Jackson]

Created attachment 290104 [details]
Patch

[Dean Jackson]

Committed r206538: <http://trac.webkit.org/changeset/206538>