Bug 162640 – Expose CryptoKey to web workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Expose CryptoKey to web workers

[Jiewen Tan]

<rdar://problem/28182204>

[Jiewen Tan]

Created attachment 290163 [details]
Patch

[Build Bot]

Comment on attachment 290163 [details]
Patch

Attachment 290163 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2165490

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html

[Build Bot]

Created attachment 290169 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290163 [details]
Patch

Attachment 290163 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2165489

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html

[Build Bot]

Created attachment 290170 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 290163 [details]
Patch

Attachment 290163 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2165498

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html

[Build Bot]

Created attachment 290173 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 290163 [details]
Patch

Attachment 290163 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2165788

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html

[Build Bot]

Created attachment 290175 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jiewen Tan]

Created attachment 290226 [details]
Patch

[Brent Fulgham]

Comment on attachment 290226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290226&action=review

Looks good! Please correct the typos I pointed out, but otherwise this looks fine.

> Source/WebCore/crypto/SerializedCryptoKeyWrap.h:37
> +// any other local storages that go through this structured clone algorithm. However, a side effect

"... any other local STORAGE that go ..."

> Source/WebCore/crypto/SerializedCryptoKeyWrap.h:38
> +// of this extra layer protection is redundant communications between mainThread(document) and

"... extra layer OF protection is ..."

> Source/WebCore/workers/WorkerGlobalScope.cpp:389
> +    bool result, done = false;

result is uninitialized here.

> Source/WebCore/workers/WorkerGlobalScope.h:149
> +    // CryptoKey data that went through structured clone algorithm to local storages such as

"... that went through THE structured clone algorithm to local STORAGE such as ..."

> Source/WebCore/workers/WorkerGlobalScope.h:152
> +    // to unwrap/wrap crypto keys. Hence, workerThreads will then ask mainThread back for unwrap/wrap

"Hence, worker threads MUST ALWAYS ask mainThread TO unwrap/wrap"

[Build Bot]

Comment on attachment 290226 [details]
Patch

Attachment 290226 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2170537

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html

[Build Bot]

Created attachment 290246 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jiewen Tan]

Created attachment 290252 [details]
Patch for landing

[Jiewen Tan]

Comment on attachment 290226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290226&action=review

Thank you Brent for reviewing my patch.

>> Source/WebCore/crypto/SerializedCryptoKeyWrap.h:37
>> +// any other local storages that go through this structured clone algorithm. However, a side effect
> 
> "... any other local STORAGE that go ..."

Fixed.

>> Source/WebCore/crypto/SerializedCryptoKeyWrap.h:38
>> +// of this extra layer protection is redundant communications between mainThread(document) and
> 
> "... extra layer OF protection is ..."

Fixed.

>> Source/WebCore/workers/WorkerGlobalScope.cpp:389
>> +    bool result, done = false;
> 
> result is uninitialized here.

Fixed.

>> Source/WebCore/workers/WorkerGlobalScope.h:149
>> +    // CryptoKey data that went through structured clone algorithm to local storages such as
> 
> "... that went through THE structured clone algorithm to local STORAGE such as ..."

Fixed.

>> Source/WebCore/workers/WorkerGlobalScope.h:152
>> +    // to unwrap/wrap crypto keys. Hence, workerThreads will then ask mainThread back for unwrap/wrap
> 
> "Hence, worker threads MUST ALWAYS ask mainThread TO unwrap/wrap"

Fixed.

[Build Bot]

Comment on attachment 290252 [details]
Patch for landing

Attachment 290252 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2170995

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html

[Build Bot]

Created attachment 290260 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jiewen Tan]

Conflicts with Brady's patch. Will upload a new one without WK2 changes.

[Jiewen Tan]

Created attachment 290263 [details]
Patch for landing

[Build Bot]

Comment on attachment 290263 [details]
Patch for landing

Attachment 290263 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2171407

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html

[Build Bot]

Created attachment 290271 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jiewen Tan]

Committed r206627: <http://trac.webkit.org/changeset/206627>