Bug 162635 - URLs with @ in the user should only search for the last @ until the end of the authority and host
Summary: URLs with @ in the user should only search for the last @ until the end of th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 15:01 PDT by Alex Christensen
Modified: 2016-09-27 17:29 PDT (History)
0 users

See Also:


Attachments
Patch (5.79 KB, patch)
2016-09-27 15:02 PDT, Alex Christensen
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-27 15:01:32 PDT
URLs with @ in the user should only search for the last @ until the end of the authority and host
Comment 1 Alex Christensen 2016-09-27 15:02:46 PDT
Created attachment 290010 [details]
Patch
Comment 2 Geoffrey Garen 2016-09-27 15:21:48 PDT
Comment on attachment 290010 [details]
Patch

r=me
Comment 3 Alex Christensen 2016-09-27 17:29:23 PDT
https://trac.webkit.org/changeset/206475
Comment 4 Alex Christensen 2016-09-27 17:29:39 PDT
Comment on attachment 290010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290010&action=review

> Source/WebCore/platform/URLParser.cpp:1331
> -                    if (UNLIKELY(!isSlash)) {
> +                    if (UNLIKELY(!isSlash || *c == '\\')) {

This was wrong.